-
Notifications
You must be signed in to change notification settings - Fork 90
plugin-flow-builder: use user locale to resolve flow locale #3198
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Iru89
merged 9 commits into
master
from
BLT-2318-plugin-flow-builder-use-user-locale-to-resolve-flow-locale
Apr 28, 2026
Merged
Changes from all commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
b2fc18b
feat: create a class to wrapp logic to resolve flow locale using user…
Iru89 c5348a5
feat: add system_locale_updated flag and send webchatSetting with upd…
Iru89 e896d50
feat: update locale rules
Iru89 c57d56d
refactor: simplify code with early returns
Iru89 191cf74
Merge branch 'master' into BLT-2318-plugin-flow-builder-use-user-loca…
Iru89 19a5d40
feat: when language detection is not enabled use system locale as a p…
Iru89 93c4019
test: refactor test with new botonic/core/testing functions and add a…
Iru89 0aa7f5f
refactor: LANGUAGE_DETECTION_ENABLED is a boolean
Iru89 0aca2db
refactor: LANGUAGE_DETECTION_ENABLED maybe undefined
Iru89 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
93 changes: 93 additions & 0 deletions
93
packages/botonic-plugin-flow-builder/src/utils/flow-locale.ts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,93 @@ | ||
| import type { BotContext } from '@botonic/core' | ||
|
|
||
| export class FlowLocale { | ||
| constructor( | ||
| private readonly botContext: BotContext, | ||
| private readonly flowLocales: string[], | ||
| private readonly defaultLocaleCode: string | ||
| ) {} | ||
|
|
||
| resolve(): string { | ||
| const priorityLocale = this.isLanguageDetectionEnabled() | ||
| ? this.getPriorityLocale() | ||
| : this.botContext.getSystemLocale() | ||
|
|
||
| if (priorityLocale) { | ||
| const exactMatch = this.matchExactLocale(priorityLocale) | ||
| if (exactMatch) { | ||
| return this.applyLocale(exactMatch) | ||
| } | ||
|
|
||
| const languageMatch = this.matchLanguage(priorityLocale) | ||
| if (languageMatch) { | ||
| return this.applyLocale(languageMatch) | ||
| } | ||
| } | ||
|
|
||
| return this.applyLocale(this.getDefaultLocale()) | ||
| } | ||
|
|
||
| private isLanguageDetectionEnabled(): boolean { | ||
| return !!this.botContext.settings.LANGUAGE_DETECTION_ENABLED | ||
| } | ||
|
|
||
| /** | ||
| * Rules: | ||
| * - If user and system languages differ, user locale takes priority. | ||
| * - If both share the same language, the more specific locale wins. | ||
| * - If both have the same specificity, user locale wins. | ||
| */ | ||
| private getPriorityLocale(): string | undefined { | ||
| const userLocale = this.botContext.getUserLocale() | ||
| const systemLocale = this.botContext.getSystemLocale() | ||
|
|
||
| if (!userLocale || !systemLocale) { | ||
| return undefined | ||
| } | ||
|
|
||
| const userLanguage = this.getLanguage(userLocale) | ||
| const systemLanguage = this.getLanguage(systemLocale) | ||
|
|
||
| if (userLanguage !== systemLanguage) { | ||
| return userLocale | ||
| } | ||
| const userIsSpecific = this.isSpecificLocale(userLocale) | ||
| const systemIsSpecific = this.isSpecificLocale(systemLocale) | ||
|
|
||
| if (userIsSpecific && !systemIsSpecific) { | ||
| return userLocale | ||
| } | ||
| if (!userIsSpecific && systemIsSpecific) { | ||
| return systemLocale | ||
| } | ||
|
|
||
| return userLocale | ||
| } | ||
|
|
||
| private matchExactLocale(locale: string): string | undefined { | ||
| return this.flowLocales.includes(locale) ? locale : undefined | ||
| } | ||
|
|
||
| private matchLanguage(locale: string): string | undefined { | ||
| const language = this.getLanguage(locale) | ||
| return this.flowLocales.includes(language) ? language : undefined | ||
| } | ||
|
|
||
| private getDefaultLocale(): string { | ||
| return this.defaultLocaleCode || 'en' | ||
| } | ||
|
|
||
| private applyLocale(locale: string): string { | ||
| this.botContext.setSystemLocale(locale) | ||
| this.botContext.session.user.system_locale_updated = true | ||
| return locale | ||
| } | ||
|
|
||
| private getLanguage(locale: string): string { | ||
| return locale.split('-')[0] | ||
| } | ||
|
|
||
| private isSpecificLocale(locale: string): boolean { | ||
| return locale.includes('-') | ||
| } | ||
| } | ||
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.