gpui: Add window composition tree - #31
Open
huacnlee wants to merge 23 commits into
Open
Conversation
Add a transparent macOS GPUI overlay surface that renders deferred window content above embedded native child views while preserving WebView input when the overlay is empty. Co-authored-by: Codex <codex@openai.com>
Co-authored-by: Codex <codex@openai.com>
Co-authored-by: Codex <codex@openai.com>
Co-authored-by: Codex <codex@openai.com>
Co-authored-by: Codex <codex@openai.com>
Co-authored-by: Codex <codex@openai.com>
Co-authored-by: Codex <codex@openai.com>
Co-authored-by: Codex <codex@openai.com>
Co-authored-by: Codex <codex@openai.com>
Split DirectComposition into base, native portal, and transparent overlay visuals. Add a platform-neutral native surface handle for binding WebView2 composition controllers. Co-authored-by: Codex <codex@openai.com>
Co-authored-by: Codex <codex@openai.com>
Co-authored-by: Codex <codex@openai.com>
Co-authored-by: Codex <codex@openai.com>
Co-authored-by: Codex <codex@openai.com>
Co-authored-by: Codex <codex@openai.com>
Co-authored-by: Codex <codex@openai.com>
huacnlee
force-pushed
the
window-composition-tree
branch
from
August 9, 2026 08:50
d640df4 to
5b1e8e4
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Objective
Solution
WindowandScene.WKWebViewembedding.native_webviewexample with the existing macOS WebKit implementation and a Windows WebView2ICoreWebView2CompositionControllerimplementation.Linux and Wayland are not included in this change. They require a separate WebKitGTK/GTK integration and cannot reuse Windows DirectComposition directly.
Testing
cargo check -p gpui --example native_webviewcargo check -p gpui_windowsSelf-Review Checklist:
Release Notes: