Skip to content

Tune LSP completions resolve capabilities to be more immediate#77

Merged
hrsh7th merged 2 commits into
hrsh7th:mainfrom
SomeoneToIgnore:better-resolve-support
Dec 10, 2024
Merged

Tune LSP completions resolve capabilities to be more immediate#77
hrsh7th merged 2 commits into
hrsh7th:mainfrom
SomeoneToIgnore:better-resolve-support

Conversation

@SomeoneToIgnore
Copy link
Copy Markdown
Contributor

@SomeoneToIgnore SomeoneToIgnore commented Dec 10, 2024

Follow-up of #75
Closes #72
Part of rust-lang/rust-analyzer#18504

As requested in #75 (comment) , I've used the original PR's change, removed filterText, sortText and restored documentation field.

On top of that, I've added command to be resolved, as additionalTextEdits are resolved anyway and its a quite rare thing to use.
From https://microsoft.github.io/language-server-protocol/specifications/lsp/3.17/specification/#completionItem

/**
 * An optional command that is executed *after* inserting this completion.
 * *Note* that additional modifications to the current document should be
 * described with the additionalTextEdits-property.
 */
command?: Command;

Comment thread lua/cmp_nvim_lsp/init.lua Outdated
Comment thread lua/cmp_nvim_lsp/init.lua
@hrsh7th
Copy link
Copy Markdown
Owner

hrsh7th commented Dec 10, 2024

I appreciate your patience.
Thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

textEdit completion item property is not resolved lazily

2 participants