feat: add maxOptionsToDisplay option to improve autocomplete performance on long lists#636
Open
pepper-lees wants to merge 1 commit intohperrin:masterfrom
Open
feat: add maxOptionsToDisplay option to improve autocomplete performance on long lists#636pepper-lees wants to merge 1 commit intohperrin:masterfrom
pepper-lees wants to merge 1 commit intohperrin:masterfrom
Conversation
…nce on long lists
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When using autocomplete with lists > 50ish in length, the creation of Svelte/DOM components in the list starts to become a performance bottleneck. It starts to become slow enough for an annoying user experience past 100. Since SMUI doesn't have any sort of virtual list component that I know of, simply limiting the number of rendered results is what I believe is a simple yet effective solution to the problem. In cases where you have a really long list but MUST render them all, then they can just keep the default value and let all the list items render.