refactor(core): remove dead code from Horde_Core_Ui_VarRenderer::factory()#101
refactor(core): remove dead code from Horde_Core_Ui_VarRenderer::factory()#101amulet1 wants to merge 1 commit into
Conversation
| { | ||
| if (is_array($driver)) { | ||
| $app = $driver[0]; | ||
| $app = Horde_String::ucfirst($driver[0]); |
There was a problem hiding this comment.
No new use of PSR-0 Horde_String - use the PSR-4 HordeString class.
| } | ||
|
|
||
| if (!$ok) { | ||
| if (!class_exists($class)) { |
There was a problem hiding this comment.
This is fine - we should not try to play autoloader.
ralflang
changed the title
|
I looked into it based on the latest code in horde: I agree that the old fallback/manual include path should not remain long-term. However, this PR is stale against current FRAMEWORK_6_0, which already contains a safer implementation using HordeString, app-name normalization, and a core renderer fallback. In RC phase I do not think we should merge a factory change that narrows runtime fallback behavior without tests across app renderers. Please rebase, update to latest horde code and add focused tests for scalar core renderer, lowercase app renderer names, missing app renderer behavior, and Composer autoload resolution. |
3 participants
No description provided.