Select from multiple instances#554
Open
harrisonhjones wants to merge 1 commit intohome-assistant:mainfrom
Open
Select from multiple instances#554harrisonhjones wants to merge 1 commit intohome-assistant:mainfrom
harrisonhjones wants to merge 1 commit intohome-assistant:mainfrom
Conversation
UplandJacob
reviewed
May 26, 2025
| layout: base_card_with_hero | ||
| javascript_source: my-index.js | ||
| description: Link to specific pages in your Home Assistant instance. | ||
| description: Link to a specific pages in your Home Assistant instances. |
frenck
changed the title
|
The Delete button should follow the HA style - it should be red as it is destructive. |
bramkragten
reviewed
Mar 13, 2026
| style="width: 100%" | ||
| @save=${this._handleSave} | ||
| @delete=${this._handleDelete} | ||
| />` /* |
bramkragten
reviewed
Mar 13, 2026
| description: Link to a specific pages in your Home Assistant instances. | ||
| --- | ||
|
|
||
| <style> |
Member
There was a problem hiding this comment.
I dont think these styles where supposed to be removed?
bramkragten
reviewed
Mar 13, 2026
| ></md-filled-text-field> | ||
| <md-filled-button @click=${this._handleSave} | ||
| >${this.value ? "Update" : "Save"}</md-filled-button | ||
| <div style="width: 100%; display: flex; flex-direction: column; align-items: start; line-break: anywhere; gap: 4px"> |
Member
There was a problem hiding this comment.
Please don't inline the styles
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a work in progress. I have not:
style=to a central locationI'm putting this out in its current state (see https://deploy-preview-554--my-home-assistant.netlify.app/) so I can get early feedback on:
I'm not super familiar with
litandmaterial-webso I may have easily made large mistakes along the way.