-
-
Notifications
You must be signed in to change notification settings - Fork 37.4k
Add pending dataset visibility and cancellation to OTBR WebSocket API #168441
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
raman325
wants to merge
6
commits into
home-assistant:dev
Choose a base branch
from
raman325:otbr-pending-dataset-websocket-api
base: dev
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+437
−0
Draft
Changes from 5 commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
5f87905
Add pending dataset visibility and cancellation to OTBR WebSocket API
raman325 d2f2aed
Add fallback for delete_pending_dataset when DELETE not supported
raman325 8ebcedf
Refactor delete_pending_dataset to use try/else instead of nested try
raman325 d4da8ad
Narrow try blocks in delete_pending_dataset fallback to API calls only
raman325 b53e631
Add comments explaining delete_pending_dataset control flow
raman325 3206ea1
Address review: narrow fallback to 405 only, remove admin from get_pe…
raman325 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
While I totally get why we'd want this, I'd like to better understand how the BR behave when it comes to cancelling pending dataset (see openthread/ot-br-posix#3308 (comment)).
Also not sure if this work around is a good idea. From what I understand the delay is really required to have the dataset propagate through the network. The 5 minutes we choose by default is a conservative high number which makes sure that even battery operated devices with long idle times get the new pending dataset (through the current channel) before we switch to the new channel.