Add Grandstream Home integration#167872
Conversation
d30e08d to
fef1454
Compare
8aad180 to
39a400b
Compare
|
The source for the library is missing: https://github.com/GrandstreamEngineering/grandstream_home_api |
f443b7c to
aa77908
Compare
It is added now |
aa77908 to
8a3b791
Compare
8a3b791 to
0b3e604
Compare
edenhaus
left a comment
There was a problem hiding this comment.
I did an initial review until I stopped as this PR is to huge. Some code needs to move to the library and also the config flow is huge. Please refactor the code and make it more readable.
Also the library needs a working workflow to deploy directly to pypi.
As 10.000 changes is to much, can we just add a single device/model in this PR and then add other models in a follow up PR. This PR needs to be a lot smaller
|
Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍 |
94772a0 to
62a2b83
Compare
62a2b83 to
3adbbd7
Compare
3adbbd7 to
a5c791e
Compare
This integration adds support for Grandstream GDS/GNS/GSC devices.
Features:
Breaking change
Proposed change
Type of change
Additional information
Checklist
ruff format homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all.To help with the load of incoming pull requests: