Skip to content

Fixing state_class for ecowitt rain sensors #159974

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
jakubcermak wants to merge 3 commits into from
+19 −5
Closed

Fixing state_class for ecowitt rain sensors #159974

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
d624c63
Fixing state_class for ecowitt rain sensors
jakubcermak Dec 29, 2025
e839d08
Merge branch 'dev' into ecowitt_state_class_fix
jakubcermak Dec 29, 2025
84de5ba
Apply suggestion from @Copilot
jakubcermak Dec 29, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 19 additions & 5 deletions homeassistant/components/ecowitt/sensor.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -257,6 +257,23 @@
),
}

RAIN_TOTAL_INCREASING_SENSOR_KEYS: Final = (
"totalrainin",
"eventrainin",
"hourlyrainin",
"dailyrainin",
"weeklyrainin",
"monthlyrainin",
"yearlyrainin",
"totalrainmm",
"eventrainmm",
"hourlyrainmm",
"dailyrainmm",
"weeklyrainmm",
"monthlyrainmm",
"yearlyrainmm",
)
Comment thread
jakubcermak marked this conversation as resolved.


async def async_setup_entry(
hass: HomeAssistant,
Expand Down Expand Up @@ -285,11 +302,8 @@ def _new_sensor(sensor: EcoWittSensor) -> None:
name=sensor.name,
)

# Only total rain needs state class for long-term statistics
if sensor.key in (
"totalrainin",
"totalrainmm",
):
# Rain sensors with cumulative values need state class for long-term statistics
if sensor.key in RAIN_TOTAL_INCREASING_SENSOR_KEYS:
description = dataclasses.replace(
description,
state_class=SensorStateClass.TOTAL_INCREASING,
Expand Down
Loading