feat: IPv6-only support#1199
Closed
mitchellrj wants to merge 2 commits intohome-assistant-libs:masterfrom
Closed
Conversation
Collaborator
|
Did you see: #1162 (ive not had time to look at it) |
Author
|
Well that PR is much neater than mine! I missed that in my search of issues. |
Collaborator
|
Could you test it and post a review? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For devices which only have IPv6 addresses, this change allows creation of IPv6 sockets or IPv4 sockets, depending on what is available.
It does not allow for Happy Eyeballs implementation on dual-stack, which would require a much larger refactor.
[abcd:1234::6789]notation is retained for HTTP connections (required to distinguish the address from the port), but stripped out for the TCP socket connection, since some implementations ofgetaddrinfodo not support this notation as input, only the raw IPv6 address.