Skip to content

Add support fo eager Narwhals dataframes#1502

Open
cakiki wants to merge 22 commits into
holoviz:mainfrom
cakiki:narwhals-eager
Open

Add support fo eager Narwhals dataframes#1502
cakiki wants to merge 22 commits into
holoviz:mainfrom
cakiki:narwhals-eager

Conversation

@cakiki

@cakiki cakiki commented May 26, 2026

Copy link
Copy Markdown
Contributor

This is a first attempt to add support for narwhals eager dataframes.

I tried as best I could to copy the pandas path.

Closes #1199 and #1496

@hoxbro hoxbro closed this May 26, 2026
@hoxbro hoxbro reopened this May 26, 2026
@codecov

codecov Bot commented May 26, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 99.59459% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 88.94%. Comparing base (c40548b) to head (962cc79).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
datashader/utils.py 91.66% 2 Missing ⚠️
datashader/tests/test_pandas.py 97.05% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1502      +/-   ##
==========================================
+ Coverage   88.47%   88.94%   +0.46%     
==========================================
  Files          96       98       +2     
  Lines       19461    20173     +712     
==========================================
+ Hits        17219    17942     +723     
+ Misses       2242     2231      -11     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@codspeed-hq

codspeed-hq Bot commented May 26, 2026

Copy link
Copy Markdown

Merging this PR will degrade performance by 22.69%

❌ 1 regressed benchmark
✅ 51 untouched benchmarks

Warning

Please fix the performance issues or acknowledge them on CodSpeed.

Performance Changes

Mode Benchmark BASE HEAD Efficiency
Simulation test_layout[forceatlas2_layout] 49.8 ms 64.4 ms -22.69%

Tip

Investigate this regression by commenting @codspeedbot fix this regression on this PR, or directly use the CodSpeed MCP with your agent.


Comparing cakiki:narwhals-eager (962cc79) with main (2c797e4)

Open in CodSpeed

@cakiki cakiki marked this pull request as ready for review May 26, 2026 14:46
@cakiki

cakiki commented Jun 15, 2026

Copy link
Copy Markdown
Contributor Author

@hoxbro this is ready I think

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Support for polars dataframes

2 participants