Development/hook#16
Merged
Merged
Conversation
so that it picks up holistics skills more reliably next time
chinh-dm-holistics
approved these changes
May 28, 2026
| esac | ||
|
|
||
| if ! command -v holistics >/dev/null 2>&1; then | ||
| emit_warning "AML file edited but the \`holistics\` CLI is not installed, so $file was not validated. Use the \`holistics-development:setup-holistics-cli\` skill to install it." |
Contributor
There was a problem hiding this comment.
In case the skill somehow can not be loaded
Suggested change
| emit_warning "AML file edited but the \`holistics\` CLI is not installed, so $file was not validated. Use the \`holistics-development:setup-holistics-cli\` skill to install it." | |
| emit_warning "AML file edited but the \`holistics\` CLI is not installed, so $file was not validated. Install holistics cli. Use the \`holistics-development:setup-holistics-cli\` skill or read https://docs.holistics.io/docs/cli." |
Collaborator
Author
There was a problem hiding this comment.
This hook is part of the plugin, the plugin contains that skill.
So I don't think this case (plugin installed but not skill) could happen
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.