fix to the coend definition#221
Open
winitzki wants to merge 2 commits intohmemcpy:masterfrom
Open
Conversation
I think the previous code for `Coend` was incorrect. The previous code was in no way different from the code for `trait PolyFunction1`, i.e. for `End`. The existential quantifier is encoded in Scala as a case class with an extra type parameter.
hmemcpy
force-pushed
the
master
branch
2 times, most recently
from
0e79320 to
4986511
Compare
Collaborator
|
Hi! I'm making a small PR cleanup. What's the status of this PR ? |
Author
|
I believe this PR fixes an error in the code. It should be reviewed and merged if accepted. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I think the previous code for
Coendwas incorrect. The previous code was in no way different from the code fortrait PolyFunction1, i.e. forEnd. TheCoendmust contain an existential quantifier. An existential quantifier is encoded in Scala as a case class with an extra type parameter. An universal quantifier is encoded as a trait with a method having a type parameter.