Skip to content

Use many break tokens. - #53

Open
kzaitsev wants to merge 2 commits into
hgmnz:masterfrom
kzaitsev:master
Open

Use many break tokens.#53
kzaitsev wants to merge 2 commits into
hgmnz:masterfrom
kzaitsev:master

Conversation

@kzaitsev

Copy link
Copy Markdown

Create new break_tokens attribute, break_token is deprecated.

@parndt

parndt commented Jun 17, 2014

Copy link
Copy Markdown
Collaborator

Thanks for this, can you please explain this in a little more details?

Also, please can you avoid changing the hash syntax in all of the tests? This makes it really hard to look at history and is unnecessary. 😄

Create new break_tokens attribute, break_token is deprecated.

Signed-off-by: Kirill Zaitsev <kirik910@gmail.com>
@kzaitsev

Copy link
Copy Markdown
Author

@parndt Thanks, il change break_token to break_tokens and transform this to array. It simple, we can have more than one break token. I have some projects when changed wysiwyg, and as a consequence pagebreak ( im use it like break token ) changes too. Of course I can change it all pagebreaks :), but i think we can use array of tokens.

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

since @break_token can be set to nil on line 9, you may want to add a protection here so you're not shoveling a nil value into your @break_tokens array. maybe something like @break_tokens << @break_token if @break_token.

if there are any nil values in @break_tokens, the code will throw an error at line 83:
NoMethodError - undefined method '<<' for nil:NilClass

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants