Skip to content

fix: normalize expired token error in GetClaimsFromJWT to ErrExpiredToken #30

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
masonsxu wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: normalize expired token error in GetClaimsFromJWT to ErrExpiredToken #30

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions auth_jwt.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -514,6 +514,15 @@ func (mw *HertzJWTMiddleware) middlewareImpl(ctx context.Context, c *app.Request
func (mw *HertzJWTMiddleware) GetClaimsFromJWT(ctx context.Context, c *app.RequestContext) (MapClaims, error) {
token, err := mw.ParseToken(ctx, c)
if err != nil {
// Normalize expired token errors to the sentinel ErrExpiredToken,
// consistent with CheckIfTokenExpire behavior.
// Without this, *jwt.ValidationError is returned as-is,
// making it impossible to match with == ErrExpiredToken downstream.
validationErr, ok := err.(*jwt.ValidationError)
if ok && validationErr.Errors == jwt.ValidationErrorExpired {
return nil, ErrExpiredToken
}

return nil, err
}

Expand Down