table widget - #2
Draft
Mchris-hub wants to merge 7 commits into
Draft
Conversation
Mchris-hub
marked this pull request as draft
February 26, 2024 14:45
hein-obox
reviewed
Feb 26, 2024
hein-obox
reviewed
Feb 26, 2024
hein-obox
reviewed
Feb 26, 2024
hein-obox
reviewed
Feb 26, 2024
hein-obox
reviewed
Feb 26, 2024
hein-obox
reviewed
Feb 26, 2024
hein-obox
reviewed
Feb 26, 2024
hein-obox
reviewed
Feb 26, 2024
hein-obox
reviewed
Feb 26, 2024
hein-obox
reviewed
Feb 26, 2024
hein-obox
reviewed
Feb 26, 2024
hein-obox
reviewed
Feb 26, 2024
hein-obox
reviewed
Feb 26, 2024
hein-obox
reviewed
Feb 26, 2024
hein-obox
reviewed
Feb 26, 2024
hein-obox
reviewed
Feb 26, 2024
hein-obox
reviewed
Feb 26, 2024
hein-obox
reviewed
Feb 26, 2024
hein-obox
reviewed
Feb 26, 2024
hein-obox
reviewed
Feb 28, 2024
hein-obox
reviewed
Feb 28, 2024
hein-obox
reviewed
Feb 28, 2024
hein-obox
reviewed
Apr 5, 2024
| */ | ||
| public function get_title() { | ||
| return esc_html__( 'testOne', 'elementor' ); | ||
| return esc_html__( 'table', 'elementor' ); |
Owner
There was a problem hiding this comment.
I think we always use capital letters here:
return esc_html__( 'Table', 'elementor' );
hein-obox
reviewed
Apr 5, 2024
| */ | ||
| public function get_keywords() { | ||
| return [ 'testOne', 'title', 'text' ]; | ||
| return [ 'table', 'title', 'text' ]; |
Author
There was a problem hiding this comment.
I removed the 'title' and the 'text'
hein-obox
reviewed
Apr 5, 2024
| 'image_alt' => esc_attr__( 'Upgrade', 'elementor' ), | ||
| 'description' => esc_html__( 'Create captivating testOnes that rotate with the Animated Headline Widget.', 'elementor' ), | ||
| 'upgrade_url' => esc_url( 'https://go.elementor.com/go-pro-testOne-widget/' ), | ||
| 'description' => esc_html__( 'Create captivating tables that rotate with the Animated Headline Widget.', 'elementor' ), |
Owner
There was a problem hiding this comment.
'description' => esc_html__( 'Create captivating tables.', 'elementor' ),
hein-obox
reviewed
Apr 5, 2024
| "eslint-plugin-react": "^7.33.2", | ||
| "eslint-webpack-plugin": "^4.0.1", | ||
| "grunt": "^1.5.3", | ||
| "grunt": "^1.6.1", |
Owner
There was a problem hiding this comment.
Please revert to the orginal value. We can't update packages on the whole repository.
hein-obox
reviewed
Apr 5, 2024
| "eslint-plugin-react": "^7.33.2", | ||
| "eslint-webpack-plugin": "^4.0.1", | ||
| "grunt": "^1.5.3", | ||
| "grunt": "^1.6.1", |
Owner
There was a problem hiding this comment.
Revert changes. We can't make updates here.
hein-obox
reviewed
Apr 5, 2024
| "eslint-plugin-react": "^7.33.2", | ||
| "eslint-webpack-plugin": "^4.0.1", | ||
| "grunt": "^1.5.3", | ||
| "grunt": "^1.6.1", |
Owner
There was a problem hiding this comment.
Revert changes. We can't make updates here.
hein-obox
reviewed
Apr 5, 2024
|
|
||
| <# if ( settings.list.length ) { #> | ||
| <tbody> | ||
| <tr> |
hein-obox
reviewed
Apr 5, 2024
| <# if ( settings.list.length ) { #> | ||
| <tbody> | ||
| <tr> | ||
| <# _.each( settings.list, function( item ) { #> |
Owner
There was a problem hiding this comment.
Suggested change
| <# _.each( settings.list, function( item ) { #> | |
| <# _.each( settings.list, function( item ) { #> | |
| <tr> |
hein-obox
reviewed
Apr 5, 2024
| <tr> | ||
| <# _.each( settings.list, function( item ) { #> | ||
| <td class="elementor-repeater-item-{{ item._id }}">{{{item.list_title}}}</td> | ||
| <# }); #> |
hein-obox
reviewed
Apr 5, 2024
| <# _.each( settings.list, function( item ) { #> | ||
| <td class="elementor-repeater-item-{{ item._id }}">{{{item.list_title}}}</td> | ||
| <# }); #> | ||
| </tr> |
Owner
There was a problem hiding this comment.
Suggested change
| </tr> | |
| </tr> | |
| <# }); #> |
hein-obox
reviewed
Apr 11, 2024
| $this->add_control( | ||
| 'rows', | ||
| [ | ||
| 'label' => esc_html__( "Rows' contents", 'elementor' ), |
Owner
There was a problem hiding this comment.
Suggested change
| 'label' => esc_html__( "Rows' contents", 'elementor' ), | |
| 'label' => esc_html__( 'Content rows', 'elementor' ), |
hein-obox
reviewed
Apr 11, 2024
| 'rows', | ||
| [ | ||
| 'label' => esc_html__( "Rows' contents", 'elementor' ), | ||
| 'show_label' => esc_html__( true, 'elementor' ), |
Owner
There was a problem hiding this comment.
Suggested change
| 'show_label' => esc_html__( true, 'elementor' ), | |
| 'show_label' => true, |
hein-obox
reviewed
Apr 11, 2024
| 'name' => 'column_content_one', | ||
| 'label' => esc_html__( 'Content column 1', 'elementor' ), | ||
| 'type' => \Elementor\Controls_Manager::TEXT, | ||
| 'default' => esc_html__( 'Content column 1' , 'elementor' ), |
hein-obox
reviewed
Apr 11, 2024
| if ( $settings['rows'] ) { | ||
| echo '<tbody>'; | ||
| $rows = $settings['rows']; | ||
| for ($i=0; $i < count($rows) - 1; $i++) { |
Owner
There was a problem hiding this comment.
I think the rows minus 1 is causing a problem.
Elementor used always spaces in between, check the other files in the repository.
Suggested change
| for ($i=0; $i < count($rows) - 1; $i++) { | |
| for ( $i=0; $i < count( $rows ); $i++ ) { |
Author
There was a problem hiding this comment.
yes I should have put <= like in the JS side
hein-obox
reviewed
Apr 11, 2024
| <# if ( settings.rows.length ) { #> | ||
| <tbody> | ||
| <# let rows = settings.rows #> | ||
| <# for(let i = 0; i <= rows.length - 1; i++){ #> |
Owner
There was a problem hiding this comment.
Suggested change
| <# for(let i = 0; i <= rows.length - 1; i++){ #> | |
| <# for( let i = 0; i <= rows.length - 1; i++ ){ #> |
hein-obox
reviewed
Apr 11, 2024
| <# let rows = settings.rows #> | ||
| <# for(let i = 0; i <= rows.length - 1; i++){ #> | ||
| <tr> | ||
| <td class="elementor-repeater-item-{{ rows[i]._id }}">{{{rows[i].column_content_one}}}</td> |
Owner
There was a problem hiding this comment.
Suggested change
| <td class="elementor-repeater-item-{{ rows[i]._id }}">{{{rows[i].column_content_one}}}</td> | |
| <td class="elementor-repeater-item-{{ rows[i]._id }}">{{{ rows[i].column_content_one }}}</td> |
hein-obox
reviewed
Apr 11, 2024
| * | ||
| * @return array Widget promotion data. | ||
| */ | ||
| protected function get_upsale_data() { |
hein-obox
reviewed
Apr 11, 2024
| } | ||
| }, | ||
| "node_modules/caniuse-lite": { | ||
| "version": "1.0.30001532", |
hein-obox
reviewed
Apr 12, 2024
| $this->add_control( | ||
| 'table_head_color', | ||
| [ | ||
| 'label' => esc_html__( 'Table head Color', 'elementor' ), |
Owner
There was a problem hiding this comment.
Use labels from Trello.
Using the correct lowercase vs uppercase is important. You can't mix it randomly.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Checklist
PR Type
What kind of change does this PR introduce?
Summary
This PR can be summarized in the following changelog entry:
Description
An explanation of what is done in this PR
Test instructions
This PR can be tested by following these steps:
Quality assurance
Fixes #