Added compatibility with osx#284
Open
xmnlab wants to merge 1 commit into
Open
Conversation
Contributor
Author
|
cc @tonyfast |
Contributor
Contributor
Author
|
Oh I see ... I didn't know that ... thanks for the explanation! I just know that it doesn't work inside a docker container.
Actually I was not planning to use systemd (because it doesn't work inside docker container) I just planned to change this script and allow it to run in macos environment (called from any folder) and on the conda build task I will comment via sed the line with
I see ... do you want to keep any of these changes in this PR? for macOS, should I create a similar file but without the systemd stuff? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In this PR:
/bin/bashto/usr/bin/env bashto allow bash from conda. This script need new bash, osx bash default is older that bash used by linux by default.idtowhoamicommand line to keep compatibility with osx