merge queue: embarking master (4db95b6) and #11786 together#11809
Closed
mergify[bot] wants to merge 2 commits intomasterfrom
Closed
merge queue: embarking master (4db95b6) and #11786 together#11809mergify[bot] wants to merge 2 commits intomasterfrom
mergify[bot] wants to merge 2 commits intomasterfrom
Conversation
Before, the number of targets were considered to be 1 always and worked mostly by accident for the empty target when no exe args were supplied. Fixes #10487 Agent-Logs-Url: https://github.com/ulysses4ever/cabal/sessions/b504e919-a7ba-422e-90d2-59528a8e5014 Co-authored-by: ulysses4ever <6832600+ulysses4ever@users.noreply.github.com> Co-authored-by: Phil de Joux <philderbeast@gmail.com> Co-authored-by: Phil de Joux <philderbeast@gmail.com>
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎉 This pull request has been checked successfully and will be merged soon. 🎉
Branch master (4db95b6) and #11786 are embarked together for merge.
This pull request has been created by Mergify to speculatively check the mergeability of #11786.
You don't need to do anything. Mergify will close this pull request automatically when it is complete.
Required conditions of queue rule
defaultfor merge:#approved-reviews-by >= 2[🛡 GitHub branch protection]cabal run's handling of--under empty target #11786#changes-requested-reviews-by = 0[🛡 GitHub branch protection]cabal run's handling of--under empty target #11786#review-threads-unresolved = 0[🛡 GitHub branch protection]cabal run's handling of--under empty target #11786check-success = Doctest Cabalcheck-neutral = Doctest Cabalcheck-skipped = Doctest Cabalcheck-success = Meta checkscheck-neutral = Meta checkscheck-skipped = Meta checkscheck-success = docs/readthedocs.org:cabalcheck-neutral = docs/readthedocs.org:cabalcheck-skipped = docs/readthedocs.org:cabalcheck-success = Validate post jobcheck-neutral = Validate post jobcheck-skipped = Validate post jobcheck-success = fourmolucheck-neutral = fourmolucheck-skipped = fourmolucheck-success = hlintcheck-neutral = hlintcheck-skipped = hlintcheck-success = Bootstrap post jobcheck-neutral = Bootstrap post jobcheck-skipped = Bootstrap post jobcheck-success = whitespacecheck-neutral = whitespacecheck-skipped = whitespacecheck-success = Check sdist post jobcheck-neutral = Check sdist post jobcheck-skipped = Check sdist post jobcheck-success = Changelogscheck-neutral = Changelogscheck-skipped = ChangelogsRequired conditions to stay in the queue:
#approved-reviews-by >= 2[🛡 GitHub branch protection]cabal run's handling of--under empty target #11786#changes-requested-reviews-by = 0[🛡 GitHub branch protection]cabal run's handling of--under empty target #11786#review-threads-unresolved = 0[🛡 GitHub branch protection]cabal run's handling of--under empty target #11786check-success = Doctest Cabalcabal run's handling of--under empty target #11786check-neutral = Doctest Cabalcabal run's handling of--under empty target #11786check-skipped = Doctest Cabalcabal run's handling of--under empty target #11786check-success = Meta checkscabal run's handling of--under empty target #11786check-neutral = Meta checkscabal run's handling of--under empty target #11786check-skipped = Meta checkscabal run's handling of--under empty target #11786check-success = docs/readthedocs.org:cabalcabal run's handling of--under empty target #11786check-neutral = docs/readthedocs.org:cabalcabal run's handling of--under empty target #11786check-skipped = docs/readthedocs.org:cabalcabal run's handling of--under empty target #11786check-success = Validate post jobcabal run's handling of--under empty target #11786check-neutral = Validate post jobcabal run's handling of--under empty target #11786check-skipped = Validate post jobcabal run's handling of--under empty target #11786check-success = fourmolucabal run's handling of--under empty target #11786check-neutral = fourmolucabal run's handling of--under empty target #11786check-skipped = fourmolucabal run's handling of--under empty target #11786check-success = hlintcabal run's handling of--under empty target #11786check-neutral = hlintcabal run's handling of--under empty target #11786check-skipped = hlintcabal run's handling of--under empty target #11786check-success = Bootstrap post jobcabal run's handling of--under empty target #11786check-neutral = Bootstrap post jobcabal run's handling of--under empty target #11786check-skipped = Bootstrap post jobcabal run's handling of--under empty target #11786check-success = whitespacecabal run's handling of--under empty target #11786check-neutral = whitespacecabal run's handling of--under empty target #11786check-skipped = whitespacecabal run's handling of--under empty target #11786check-success = Check sdist post jobcabal run's handling of--under empty target #11786check-neutral = Check sdist post jobcabal run's handling of--under empty target #11786check-skipped = Check sdist post jobcabal run's handling of--under empty target #11786check-success = Changelogscabal run's handling of--under empty target #11786check-neutral = Changelogscabal run's handling of--under empty target #11786check-skipped = Changelogscabal run's handling of--under empty target #11786