Backport #10548: Print info about current project file in use to stderr and ignore the imports by default#10550
Merged
Merged
Conversation
… imports by default (#10548) * Print info about current project file in use to stderr (fix #10547) * only report top-level project config files in the default verbosity in verbose mode report imported files too * fix tests * don't print anything when provenance is empty * fix tests * Apply suggestions from code review Co-authored-by: ffaf1 <fa-ml@ariis.it> --------- Co-authored-by: ffaf1 <fa-ml@ariis.it> (cherry picked from commit 7de199a) # Conflicts: # cabal-testsuite/PackageTests/ConditionalAndImport/cabal.out
Contributor
Author
|
Cherry-pick of 7de199a has failed: To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally |
Merged
4 tasks
ulysses4ever
approved these changes
Nov 13, 2024
578f431 to
2692a22
Compare
Collaborator
|
If anyone wants to try to fix up the test, I'd appreciate that since I'm traveling during this week. |
2692a22 to
de3bb02
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix #10547 by printing the project config info to stderr.
Also, report only top-level project configs with the default verbosity. Otherwise, imported config files can still be seen in the verbose mode.
Manual Q/A
Try to reproduce #10547
Template Α: This PR modifies behaviour or interface
Include the following checklist in your PR:
Any changes that could be relevant to users have been recorded in the changelog.Is the change significant? If so, remember to addsignificance: significantin the changelog file.This is an automatic backport of pull request #10548 done by [Mergify](https://mergify.com).