Skip to content

Update Rust crate deadpool to 0.13.0 #8700

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
hash-worker wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Update Rust crate deadpool to 0.13.0 #8700

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
37 changes: 24 additions & 13 deletions Cargo.lock
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -136,7 +136,7 @@ criterion = { version = "0.8.0", default-features = fal
criterion-macro = { version = "0.4.0", default-features = false }
dashu-base = { version = "0.4.1", default-features = false }
dashu-float = { version = "0.4.3", default-features = false }
deadpool = { version = "0.12.3", default-features = false }
deadpool = { version = "0.13.0", default-features = false }
Copy link
Copy Markdown

@augmentcode augmentcode Bot May 6, 2026 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cargo.toml:139 — deadpool-postgres 0.14.1 depends on deadpool ^0.12, so bumping the workspace deadpool to 0.13 can introduce two deadpool versions and lead to type incompatibilities if any crate ends up using both directly. It may be worth double-checking the dependency graph/usages to ensure everything is consistently on the same deadpool API surface.

Severity: medium

Fix This in Augment

🤖 Was this useful? React with 👍 or 👎, or 🚀 if it prevented an incident/outage.

Copy link
Copy Markdown

@cursor cursor Bot May 6, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Incompatible deadpool versions between direct and transitive dependencies

High Severity

Upgrading deadpool to 0.13.0 while deadpool-postgres (0.14.1) still depends on deadpool ^0.12.0 introduces two incompatible versions of deadpool in the dependency tree. The hash-graph-postgres-store crate declares deadpool as public = true, so downstream consumers see deadpool 0.13.0 types, but deadpool-postgres exposes types (like Pool, PoolConfig, PoolError) based on deadpool 0.12.3. These types are not interchangeable across semver-incompatible 0.x versions in Rust. No version of deadpool-postgres currently supports deadpool 0.13.0.

Additional Locations (2)
Fix in Cursor Fix in Web

Reviewed by Cursor Bugbot for commit 252d9ba. Configure here.

deadpool-postgres = { version = "0.14.1", default-features = false }
derive-where = { version = "1.6.0", default-features = false, features = ["nightly"] }
derive_more = { version = "2.0.1", default-features = false }
Expand Down
Loading