Skip to content

BE-513: HashQL: Rework dynamic aggregate size estimation #8697

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
indietyp wants to merge 4 commits into
base: bm/be-512-hashql-switchint-allow-cross-backend-transitions
Choose a base branch
from

chore: truncate instead of resize on mul

80db587
Select commit
Loading
Failed to load commit list.
Open

BE-513: HashQL: Rework dynamic aggregate size estimation #8697

chore: truncate instead of resize on mul
80db587
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded May 11, 2026 in 0s

57.51% (+0.23%) compared to f2fc415

View this Pull Request on Codecov

57.51% (+0.23%) compared to f2fc415

Details

Codecov Report

❌ Patch coverage is 91.07143% with 30 lines in your changes missing coverage. Please review.
✅ Project coverage is 57.51%. Comparing base (f2fc415) to head (80db587).

Files with missing lines Patch % Lines
...l/mir/src/pass/analysis/size_estimation/dynamic.rs 73.49% 22 Missing ⚠️
...mir/src/pass/analysis/size_estimation/footprint.rs 92.15% 4 Missing and 4 partials ⚠️
Additional details and impacted files 
@@                                      Coverage Diff                                       @@
##           bm/be-512-hashql-switchint-allow-cross-backend-transitions    #8697      +/-   ##
==============================================================================================
+ Coverage                                                       57.27%   57.51%   +0.23%     
==============================================================================================
  Files                                                             698      698              
  Lines                                                           53602    53930     +328     
  Branches                                                         3616     3623       +7     
==============================================================================================
+ Hits                                                            30702    31016     +314     
- Misses                                                          22604    22615      +11     
- Partials                                                          296      299       +3

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
View more details on Codecov