Skip to content

Update Rust crate bump-scope to v2 #8695

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
hash-worker wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Update Rust crate bump-scope to v2 #8695

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions Cargo.lock
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -117,7 +117,7 @@ axum-core = { version = "0.5.5" }
bitvec = { version = "1.0.1", default-features = false }
bon = { version = "3.8.1", default-features = false, features = ["implied-bounds"] }
bstr = { version = "1.12.1" }
bump-scope = { version = "1.5.1", default-features = false, features = ["alloc", "nightly-clone-to-uninit", "panic-on-alloc", "std"] }
bump-scope = { version = "2.0.0", default-features = false, features = ["alloc", "nightly-clone-to-uninit", "panic-on-alloc", "std"] }
Copy link
Copy Markdown

@augmentcode augmentcode Bot May 4, 2026 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bump-scope v2 changed scoped to call the closure with &mut BumpScope (instead of an owned BumpScope), but libs/@local/hashql/core/src/heap/allocator.rs currently appears to assume an owned scope (AllocatorScope(scope)), so this bump may break hashql-core’s allocator wrappers.
Please double-check those wrappers against the v2 API (e.g., whether converting via by_value() is required) before merging.

Severity: high

Fix This in Augment

🤖 Was this useful? React with 👍 or 👎, or 🚀 if it prevented an incident/outage.

bytes = { version = "1.10.1" }
bytes-utils = { version = "0.1.4", default-features = false }
camino = { version = "1.1.12", default-features = false }
Expand Down
Loading