-
Notifications
You must be signed in to change notification settings - Fork 121
FE-647: Add button component
#8687
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
33 commits
Select commit
Hold shift + click to select a range
9dcf554
Added button component stub
alex-e-leon d9e3184
Basic button styles
alex-e-leon d3df058
Button variant styles
alex-e-leon 0263d4d
Button variant styles
alex-e-leon 6452ab8
Fixed styles for button styles
alex-e-leon 35960c2
Add loading spinner on black background story
alex-e-leon c1ec0e6
Fix loading spinner on black
alex-e-leon 53d4979
Add button loading spinner variant
alex-e-leon ecb6b9b
Better button icon padding
alex-e-leon cb4a85a
Square icon buttons
alex-e-leon b800a39
Fix button transitions
alex-e-leon 4f81009
Add min-width to button for square buttons
alex-e-leon e0c06e1
Added pre+suff icon
alex-e-leon 410bb70
Fix button story lint issues
alex-e-leon 0d7143f
Fix lint errors
alex-e-leon 49d34e3
Update petrinaut button components
alex-e-leon d8a21b6
Added link subtle back in
alex-e-leon 659b6c0
Added changeset
alex-e-leon 9828a92
Switch button min-width to use border-variable width
alex-e-leon 4a2ba80
bump button font-weigh to 500 + make subtle button bg transparent
alex-e-leon 89dcdd9
Added an xxs size to button
alex-e-leon 06bc906
Match prefix + suffix icon sizes in button story
alex-e-leon 88a353e
Fix petrinaut button props
alex-e-leon 59b8d64
remove href if link is disabled
alex-e-leon a415ed1
Add extra link styles to button
alex-e-leon 12580c4
Fix min-width on links
alex-e-leon daf1aaa
Use variable for icon margin
alex-e-leon 650fb9a
Switch line-height to be a js value rather than a calculated value
alex-e-leon 9ecf1a5
Added click to load story example
alex-e-leon 03de19a
Revert "Switch line-height to be a js value rather than a calculated …
alex-e-leon 8ec08d9
Don't add ref twice to button
alex-e-leon 1b647e6
Useless commit to re-trigger GH CI
alex-e-leon abc9787
Fix ds-components turbo dependencies
alex-e-leon File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,5 @@ | ||
| --- | ||
| "@hashintel/ds-components": patch | ||
| --- | ||
|
|
||
| New Button component added to design system |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.