-
Notifications
You must be signed in to change notification settings - Fork 121
BE-455: HashQL: Introduce evaluation orchestrator #8586
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
indietyp
wants to merge
4
commits into
bm/be-523-hashql-suspendable-interpreter-with-structured-values-and
Choose a base branch
from
bm/be-455-hashql-create-evaluation-target-coordinator
base: bm/be-523-hashql-suspendable-interpreter-with-structured-values-and
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,19 @@ | ||
| #!/usr/bin/env bash | ||
| set -e | ||
| if [[ ! -d "/Users/bmahmoud/projects/hash/hash" ]]; then | ||
| echo "Cannot find source directory; Did you move it?" | ||
| echo "(Looking for "/Users/bmahmoud/projects/hash/hash")" | ||
| echo 'Cannot force reload with this script - use "direnv reload" manually and then try again' | ||
| exit 1 | ||
| fi | ||
|
|
||
| # rebuild the cache forcefully | ||
| _nix_direnv_force_reload=1 direnv exec "/Users/bmahmoud/projects/hash/hash" true | ||
|
|
||
| # Update the mtime for .envrc. | ||
| # This will cause direnv to reload again - but without re-building. | ||
| touch "/Users/bmahmoud/projects/hash/hash/.envrc" | ||
|
|
||
| # Also update the timestamp of whatever profile_rc we have. | ||
| # This makes sure that we know we are up to date. | ||
| touch -r "/Users/bmahmoud/projects/hash/hash/.envrc" "/Users/bmahmoud/projects/hash/hash/.direnv"/*.rc | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1 @@ | ||
| /nix/store/1vl291j7zmnqw700hyj840j9yqv94plk-source |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1 @@ | ||
| /nix/store/hh6i9rnxx1v6azzva6dc3ivglh9bxnzg-source |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1 @@ | ||
| /nix/store/in6vrz0r1n0f68mhilqxjjn3zzi5qxbi-source |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1 @@ | ||
| /nix/store/q39dfs8rf29qhi1qf5m0hifj1gf586lf-source |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1 @@ | ||
| /nix/store/wjfxdzblindbl9sp2hbwhi4iyh5jh348-source |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1 @@ | ||
| /nix/store/ylxkr484a1vy6ax7c02vca6f52pd56v4-source |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1 @@ | ||
| /nix/store/a8x6mxizkswsamqg3rx44c6fnw1g5nl5-hash-env |
69 changes: 69 additions & 0 deletions
69
.direnv/flake-profile-a5d5b61aa8a61b7d9d765e1daf971a9a578f1cfa.rc
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,69 @@ | ||
| unset shellHook | ||
| PATH=${PATH:-} | ||
| nix_saved_PATH="$PATH" | ||
| XDG_DATA_DIRS=${XDG_DATA_DIRS:-} | ||
| nix_saved_XDG_DATA_DIRS="$XDG_DATA_DIRS" | ||
| BASH='/sbin/nologin' | ||
| HOSTTYPE='aarch64' | ||
| IFS=' | ||
| ' | ||
| IN_NIX_SHELL='impure' | ||
| export IN_NIX_SHELL | ||
| LINENO='80' | ||
| MACHTYPE='aarch64-apple-darwin25.3.0' | ||
| NIX_BUILD_CORES='18' | ||
| export NIX_BUILD_CORES | ||
| NIX_STORE='/nix/store' | ||
| export NIX_STORE | ||
| OLDPWD='' | ||
| export OLDPWD | ||
| OPTERR='1' | ||
| OSTYPE='darwin25.3.0' | ||
| PATH='/path-not-set' | ||
| export PATH | ||
| PS4='+ ' | ||
| SHELL='/sbin/nologin' | ||
| builder='/nix/store/in4yc03diyvs2n2wgf3nva4hbvml8v1j-bash-interactive-5.3p9/bin/bash' | ||
| export builder | ||
| dontAddDisableDepTrack='1' | ||
| export dontAddDisableDepTrack | ||
| name='hash-env' | ||
| export name | ||
| out='/Users/bmahmoud/projects/hash/hash/outputs/out' | ||
| export out | ||
| outputs='out' | ||
| shellHook='# Remove all the unnecessary noise that is set by the build env | ||
| unset NIX_BUILD_TOP NIX_BUILD_CORES NIX_STORE | ||
| unset TEMP TEMPDIR TMP TMPDIR | ||
| # $name variable is preserved to keep it compatible with pure shell https://github.com/sindresorhus/pure/blob/47c0c881f0e7cfdb5eaccd335f52ad17b897c060/pure.zsh#L235 | ||
| unset builder out shellHook stdenv system | ||
| # Flakes stuff | ||
| unset dontAddDisableDepTrack outputs | ||
|
|
||
| # For `nix develop`. We get /noshell on Linux and /sbin/nologin on macOS. | ||
| if [[ "$SHELL" == "/noshell" || "$SHELL" == "/sbin/nologin" ]]; then | ||
| export SHELL=/nix/store/in4yc03diyvs2n2wgf3nva4hbvml8v1j-bash-interactive-5.3p9/bin/bash | ||
| fi | ||
|
|
||
| # Load the environment | ||
| source "/nix/store/z6v9sv2fk37bc7adkmfdgjjjfzhyyflz-hash-dir/env.bash" | ||
| ' | ||
| export shellHook | ||
| stdenv='/nix/store/c0pzk2bfla7hyzwq4vq6rk92m5dpwa4j-naked-stdenv' | ||
| export stdenv | ||
| system='aarch64-darwin' | ||
| export system | ||
| runHook () | ||
| { | ||
|
|
||
| eval "$shellHook"; | ||
| unset runHook | ||
| } | ||
| PATH="$PATH${nix_saved_PATH:+:$nix_saved_PATH}" | ||
| XDG_DATA_DIRS="$XDG_DATA_DIRS${nix_saved_XDG_DATA_DIRS:+:$nix_saved_XDG_DATA_DIRS}" | ||
| export NIX_BUILD_TOP="$(mktemp -d -t nix-shell.XXXXXX)" | ||
| export TMP="$NIX_BUILD_TOP" | ||
| export TMPDIR="$NIX_BUILD_TOP" | ||
| export TEMP="$NIX_BUILD_TOP" | ||
| export TEMPDIR="$NIX_BUILD_TOP" | ||
| eval "${shellHook:-}" |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Local development
.direnvfiles accidentally committedHigh Severity
The entire
.direnv/directory has been committed, containing machine-specific nix-direnv configuration files. These include hardcoded local paths (/Users/bmahmoud/projects/hash/hash), nix store references, and environment variable exports tied to a specific developer's machine. The.gitignorehas no entry for.direnv, so this will persist and potentially cause conflicts for other developers. These files are auto-generated bydirenvand should never be version-controlled.Additional Locations (1)
.direnv/flake-profile-a5d5b61aa8a61b7d9d765e1daf971a9a578f1cfa.rc#L1-L69Reviewed by Cursor Bugbot for commit b4765d0. Configure here.