Skip to content

FE-705: Planning extensions and persistence facade cleanup#133

Merged
lunelson merged 16 commits into
mainfrom
ln/fe-705-extensions
May 15, 2026
Merged

FE-705: Planning extensions and persistence facade cleanup#133
lunelson merged 16 commits into
mainfrom
ln/fe-705-extensions

Conversation

@lunelson
Copy link
Copy Markdown
Contributor

@lunelson lunelson commented May 13, 2026

Summary

Follow-up FE-705 branch that cleans up the workflow/planning layer around the agent capability work, extracts the persistence facade into focused store modules, and records the coordination strategy for moving routes and capabilities toward shared backend authority without forcing an early frontend cutover.

What changed

  • Added/refined ln-* workflow guidance, including ln-disambiguate, the updated spec template, and the colleague-facing docs/praxis/ln-skills.md reference.
  • Restructured live planning memory around the mature SPEC.md / PLAN.md shape and captured the FE-701 changeset-ledger sequencing/migration observations.
  • Split src/server/db.ts into a public facade plus private src/server/db/*-store.ts modules for annotation, reconciliation, edit-impact, intent-graph, review materialization, entity projection, workflow, and specification persistence.
  • Added docs/design/SUBSTRATE_STRANGLER_COORDINATION.md to coordinate parallel backend-substrate and frontend-artifact work: existing REST/SSE contracts stay stable while route adapters and capability adapters converge on shared server-owned handlers.
  • Fixed completed live tool activity rendering so output-only tool parts remain summarized/collapsed instead of exposing target details as if a tool were still running.

Verification

  • npm run test -- src/client/routes/specification/\$id/_view/__tests__/InterviewView.test.tsx -t "renders live workspace-tool activity during the submitted pre-stream generating window"
  • npm run test -- src/client/routes/specification/\$id/_view/__tests__/-interview-controller.test.tsx -t "surfaces live tool targets and running state while the generating placeholder is active"
  • npm run verify was run locally after the fix and did not complete cleanly due to currently observed unrelated/flaky failures:
    • src/server/side-chat-route.test.tsreturns 404 when the specification does not exist (socket hang up).
    • src/server/cli.test.tsexecutes through the package bin wrapper timed out at 5000ms.
    • Lint still reports 6 existing no-unused-vars warnings around rendered test variables, but no lint errors.

Copy link
Copy Markdown
Contributor Author

lunelson commented May 13, 2026

This stack of pull requests is managed by Graphite. Learn more about stacking.

@lunelson lunelson changed the title add new ln-disambiguate skill FE-705: WIP Enhancements May 13, 2026
@lunelson lunelson changed the title FE-705: WIP Enhancements FE-705: Planning extensions and persistence facade cleanup May 13, 2026
@lunelson lunelson marked this pull request as ready for review May 13, 2026 15:28
@lunelson lunelson self-assigned this May 13, 2026
@cursor
Copy link
Copy Markdown

cursor Bot commented May 13, 2026

PR Summary

Medium Risk
Changes are largely workflow/docs, but they update canonical memory/PLAN.md and agent skill routing/templates that could materially affect how future work is planned and executed.

Overview
Updates the project’s ln-* workflow by adding a new ln-disambiguate skill and revising ln-consult, ln-design, and ln-review to emphasize ambiguity collapse, deep-module seam design, and a clearer review-to-design escalation path.

Reworks ln-spec, ln-sync, and the SPEC template toward a mature memory/SPEC.md structure (Product Contract / Live Architecture Register / Future Direction), with tighter rules for traceability, unit-of-record hygiene, and retiring validated assumptions.

Adds colleague-facing reference docs (docs/praxis/ln-skills.md) plus a new coordination note (docs/design/SUBSTRATE_STRANGLER_COORDINATION.md), and updates memory/PLAN.md sequencing/traceability to reflect the FE-701 changeset-ledger posture and the new strangler-migration coordination framing.

Reviewed by Cursor Bugbot for commit 8011cf6. Bugbot is set up for automated code reviews on this repo. Configure here.

@lunelson lunelson requested a review from kostandinang May 13, 2026 15:28
@augmentcode
Copy link
Copy Markdown

augmentcode Bot commented May 13, 2026

This pull request is abnormally large and would use a significant amount of tokens to review. If you still wish to review it, comment "augment review" and we will review it.

kostandinang added a commit that referenced this pull request May 13, 2026
memory/PLAN.md and docs/archive/PLAN_HISTORY.md changes from this branch
will land as a planning-only PR off main after Lu's #132 + #133 stack
merges, per the planning-pr convention (known merge conflicts on planning
docs + frontier-definitions migration triggers separate-PR recommendation).

This keeps PR #134 code-only and conflict-free with Lu's stack.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
@lunelson
Copy link
Copy Markdown
Contributor Author

augment review

@augmentcode
Copy link
Copy Markdown

augmentcode Bot commented May 14, 2026

🤖 Augment PR Summary

Summary: This PR extends the ln-* workflow/planning layer and restructures the persistence facade into focused store modules, alongside planning document cleanup and a targeted UI fix.

Changes:

  • Added a new ln-disambiguate skill for contrastive-example ambiguity collapse, and updated ln-review/ln-design/ln-consult/ln-spec/ln-sync with deepening-candidate routing, mature SPEC shape guidance, and validated-assumption retirement rules.
  • Created docs/praxis/ln-skills.md as a colleague-facing reference for the full skill system.
  • Split the monolithic src/server/db.ts (~1600 lines) into a public facade plus 8 private src/server/db/*-store.ts modules (annotation, reconciliation, edit-impact, intent-graph, review-materialization, entity-projection, workflow, specification).
  • Restructured memory/SPEC.md into a mature shape: Product Contract, Live Architecture Register, Future Direction Register, compact Lexicon, and Verification Design — retiring embedded/validated assumptions and compressing overlapping decisions.
  • Added docs/design/SUBSTRATE_STRANGLER_COORDINATION.md documenting the strategy for migrating routes/capabilities toward shared backend handlers without premature frontend cutover.
  • Fixed completed live tool activity rendering so output-only tool parts remain summarized/collapsed instead of appearing as if still running.

Technical Notes: The db.ts split follows the repo's fractal sub-tree pattern: db.ts remains the public entry point re-exporting all functions/types, while private store modules each import type { DB } from the parent (type-only circular import, safe at runtime). Some helper functions (getActivePath, getTurn) are duplicated as private copies across store modules to avoid runtime circular dependencies.

🤖 Was this summary useful? React with 👍 or 👎

Copy link
Copy Markdown

@augmentcode augmentcode Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review completed. 2 suggestions posted.

Fix All in Augment

Comment augment review to trigger a new review at any time.

Comment thread src/server/db.ts Outdated
Comment thread src/server/db/workflow-store.ts Outdated
@lunelson lunelson force-pushed the ln/fe-705-extensions branch from a4827a2 to 36c3fad Compare May 15, 2026 07:54
@lunelson lunelson force-pushed the ln/fe-705-cli-capabilities-with-docs-and-skills-update branch from f438c7d to ad7301a Compare May 15, 2026 07:58
@lunelson lunelson force-pushed the ln/fe-705-extensions branch 2 times, most recently from 8f28aa9 to 9b0fb37 Compare May 15, 2026 10:58
@lunelson lunelson force-pushed the ln/fe-705-cli-capabilities-with-docs-and-skills-update branch from ad7301a to b7a6f9e Compare May 15, 2026 10:58
@kostandinang kostandinang force-pushed the ln/fe-705-extensions branch from 9b0fb37 to a4827a2 Compare May 15, 2026 11:23
@kostandinang kostandinang force-pushed the ln/fe-705-cli-capabilities-with-docs-and-skills-update branch from b7a6f9e to 1bcd5a7 Compare May 15, 2026 11:23
@kostandinang kostandinang force-pushed the ln/fe-705-extensions branch from a4827a2 to 9b0fb37 Compare May 15, 2026 11:24
@lunelson lunelson force-pushed the ln/fe-705-extensions branch from 9b0fb37 to b09adc4 Compare May 15, 2026 12:25
kostandinang
kostandinang previously approved these changes May 15, 2026
Base automatically changed from ln/fe-705-cli-capabilities-with-docs-and-skills-update to main May 15, 2026 12:29
@lunelson lunelson force-pushed the ln/fe-705-extensions branch from b09adc4 to 8011cf6 Compare May 15, 2026 12:30
@github-actions github-actions Bot dismissed kostandinang’s stale review May 15, 2026 12:30

Latest approval commit b09adc4 is not an ancestor of 8011cf6, indicating rewritten history after approval

@graphite-app
Copy link
Copy Markdown

graphite-app Bot commented May 15, 2026

Merge activity

  • May 15, 12:31 PM UTC: Graphite rebased this pull request, because this pull request is set to merge when ready.

@lunelson lunelson requested a review from kostandinang May 15, 2026 12:31
@lunelson lunelson added this pull request to the merge queue May 15, 2026
Merged via the queue into main with commit e90a4c5 May 15, 2026
6 checks passed
@lunelson lunelson deleted the ln/fe-705-extensions branch May 15, 2026 13:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants