workflows: enforce list resource implementation for new resources#32173
Open
workflows: enforce list resource implementation for new resources#32173
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Community Note
Description
This PR adds a new CI workflow that enforces all new resources added to the provider include a corresponding list resource implementation (
*_resource_list.go).With the introduction of the
listblock in Terraform 1.14+, every resource in the provider should support listing. This check ensures new resources aren't merged without their list implementation, preventing us from accumulating more list-resource debt.How it works:
scripts/enforce-list-for-new-resources.sh) diffs the PR againstorigin/mainto detect newly added*_resource.gofiles*_resource_list.gofile existsSkipping the check:
allow-without-listlabel can be applied to the PR to skip the checkPR Checklist
Changes to existing Resource / Data Source
N/A - This PR only adds CI tooling.
Change Log
enforce-list-resourcesworkflow to require list resource implementations for new resourcesThis is a (please select all that apply):
Related Issue(s)
N/A
AI Assistance Disclosure
Script and workflow were generated with AI assistance, reviewed and tested locally.
Rollback Plan
If a change needs to be reverted, we will publish an updated version of the provider.
Changes to Security Controls
No changes to security controls.