Skip to content

docs: improve azurerm_firewall_policy example usage#32172

Closed
yosofbadr wants to merge 1 commit intohashicorp:mainfrom
yosofbadr:docs/firewall-policy-example
Closed

docs: improve azurerm_firewall_policy example usage#32172
yosofbadr wants to merge 1 commit intohashicorp:mainfrom
yosofbadr:docs/firewall-policy-example

Conversation

@yosofbadr
Copy link
Copy Markdown

@yosofbadr yosofbadr commented Apr 15, 2026

Summary

  • Adds a comprehensive "Complete Example" to the azurerm_firewall_policy documentation showing all optional blocks with Premium SKU
  • Includes working examples of: dns, identity, insights (with log_analytics_workspace), intrusion_detection (with signature_overrides, traffic_bypass, and private_ranges), threat_intelligence_allowlist, tls_certificate, explicit_proxy, private_ip_ranges, auto_learn_private_ranges_enabled, sql_redirect_allowed, and tags
  • Retains the existing minimal example for basic usage

Fixes #15585

Test plan

  • Verify the HCL example is syntactically valid
  • Confirm all optional blocks documented in the Arguments Reference are represented in the new example
  • Review that supporting resources (Key Vault, User Assigned Identity, IP Groups, Log Analytics Workspace) are correctly defined

Add a comprehensive example showing all optional blocks for the
azurerm_firewall_policy resource with Premium SKU, including dns,
identity, insights, intrusion_detection, threat_intelligence_allowlist,
tls_certificate, explicit_proxy, and related supporting resources.

Fixes hashicorp#15585
@yosofbadr yosofbadr marked this pull request as ready for review April 15, 2026 20:21
@yosofbadr yosofbadr requested review from a team, WodansSon and magodo as code owners April 15, 2026 20:21
@sreallymatt
Copy link
Copy Markdown
Collaborator

Hi @yosofbadr - as mentioned in #31006, we generally don't add multiple large examples in the documentation. The documentation examples are meant to serve as a basic starting point, not a complete usage example.

For larger and/or more complex examples, the examples directory in the repository could be used.

@sreallymatt sreallymatt self-assigned this Apr 16, 2026
@yosofbadr
Copy link
Copy Markdown
Author

Thanks for the review and the pointer to #31006, @sreallymatt. That makes sense — the docs examples should stay as a minimal starting point. Closing this PR; happy to re-propose this as an addition to the examples directory if that would be useful.

@yosofbadr yosofbadr closed this Apr 21, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

azurerm_firewall_policy Example Usage Improvement

2 participants