New Resource: `azurerm_compute_fleet` by sinbai · Pull Request #28758 · hashicorp/terraform-provider-azurerm

sinbai · 2025-02-12T09:38:32Z

Community Note

Please vote on this PR by adding a 👍 reaction to the original PR to help the community and maintainers prioritize for review
Please do not leave comments along the lines of "+1", "me too" or "any updates", they generate extra noise for PR followers and do not help prioritize for review

Description

API: https://github.com/Azure/azure-rest-api-specs/blob/main/specification/azurefleet/resource-manager/Microsoft.AzureFleet/stable/2024-11-01/azurefleet.json

Doc: https://learn.microsoft.com/en-us/azure/azure-compute-fleet/overview

Note: TC test subscription account needs to register Microsoft.AzureFleet namespace

PR Checklist

I have followed the guidelines in our Contributing Documentation.
I have checked to ensure there aren't other open Pull Requests for the same update/change.
[] I have checked if my changes close any open issues. If so please include appropriate closing keywords below.
I have updated/added Documentation as required written in a helpful and kind way to assist users that may be unfamiliar with the resource / data source.
I have used a meaningful PR title to help maintainers and other users understand this change and help prevent duplicate work.
For example: “resource_name_here - description of change e.g. adding property new_property_name_here”

Changes to existing Resource / Data Source

I have added an explanation of what my changes do and why I'd like you to include them (This may be covered by linking to an issue above, but may benefit from additional explanation).
I have written new tests for my resource or datasource changes & updated any relevant documentation.
I have successfully run tests with my changes locally. If not, please provide details on testing challenges that prevented you running the tests.
(For changes that include a state migration only). I have manually tested the migration path between relevant versions of the provider.

Testing

My submission includes Test coverage as described in the Contribution Guide and the tests pass. (if this is not possible for any reason, please include details of why you did or could not add test coverage)


PASS: TestAccComputeFleet_virtualMachineProfileImage_imageFromSharedImageGalleryVersion (1674.34s)
PASS: TestAccComputeFleet_virtualMachineProfileImage_imageFromSharedImageGallery (1618.08s)
PASS: TestAccComputeFleet_virtualMachineProfileImage_imageFromCommunitySharedImageGalleryVersion (1720.16s)
PASS: TestAccComputeFleet_virtualMachineProfileImage_imageFromCommunitySharedImageGallery (1772.22s)
PASS: TestAccComputeFleet_virtualMachineProfileImage_imageFromImageId (688.07s)
PASS: TestAccComputeFleet_virtualMachineProfileImage_imageFromImageSourceReference (583.79s)
PASS: TestAccComputeFleet_virtualMachineProfileExtensions_complete (238.23s)
PASS: TestAccComputeFleet_virtualMachineProfileExtensions_protectedSettingsFromKeyVault (768.25s)
PASS: TestAccComputeFleet_virtualMachineProfileExtensions_basic (233.85s)
PASS: TestAccComputeFleet_virtualMachineProfileExtensions_update (548.34s)
PASS: TestAccComputeFleet_virtualMachineProfileAuth_authMultipleSSHPublicKeys (616.67s)
PASS: TestAccComputeFleet_virtualMachineProfileAuth_authSSHKey (612.78s)
PASS: TestAccComputeFleet_virtualMachineProfileAuth_authPassword (491.86s)
PASS: TestAccComputeFleet_virtualMachineProfileAuth_authEd25519SSHPublicKeys (446.14s)
PASS: TestAccComputeFleet_virtualMachineProfileAuth_authSSHKeyAndPassword (433.36s)
PASS: TestAccComputeFleet_completeExceptVMSS (323.73s)
PASS: TestAccComputeFleet_update (503.19s)
PASS: TestAccComputeFleet_requiresImport (304.98s)
PASS: TestAccComputeFleet_basic (276.35s)
PASS: TestAccComputeFleet_virtualMachineProfileOthers_UserData (544.01s)
PASS: TestAccComputeFleet_virtualMachineProfileOthers_scheduledEvent (550.24s)
PASS: TestAccComputeFleet_virtualMachineProfileOthers_licenseType (560.89s)
PASS: TestAccComputeFleet_virtualMachineProfileOthers_bootDiagnosticEnabled (537.74s)
PASS: TestAccComputeFleet_virtualMachineProfileOthers_galleryApplication (1636.13s)
PASS: TestAccComputeFleet_virtualMachineProfileOthers_securityProfile (409.62s)
PASS: TestAccComputeFleet_virtualMachineProfileOthers_additionalCapabilitiesHibernation (359.61s)
PASS: TestAccComputeFleet_virtualMachineProfileOthers_additionalCapabilitiesUltraSSD (357.57s)
PASS: TestAccComputeFleet_virtualMachineProfileOsProfile_windowsUpdate (774.72s)
PASS: TestAccComputeFleet_virtualMachineProfileOsProfile_windowsComplete (623.81s)
PASS: TestAccComputeFleet_virtualMachineProfileOsProfile_linuxBasic (322.43s)
PASS: TestAccComputeFleet_virtualMachineProfileOsProfile_linuxUpdate (1631.18s)
PASS: TestAccComputeFleet_virtualMachineProfileOsProfile_windowsBasic (360.23s)
PASS: TestAccComputeFleet_virtualMachineProfileOsProfile_linuxComplete (532.94s)
PASS: TestAccComputeFleet_virtualMachineProfileOsDisk_complete (536.28s)
PASS: TestAccComputeFleet_virtualMachineProfileOsDisk_update (1235.23s)
PASS: TestAccComputeFleet_virtualMachineProfileOsDisk_basic (330.43s)
PASS: TestAccComputeFleet_virtualMachineProfileNetwork_basic (379.29s)
PASS: TestAccComputeFleet_virtualMachineProfileNetwork_updateForBaseVirtualMachineProfile (1878.72s)
PASS: TestAccComputeFleet_virtualMachineProfileNetwork_updateForAdditionalLocation (2297.68s)
PASS: TestAccComputeFleet_virtualMachineProfileNetwork_completeForBaseVirtualMachineProfile (836.75s)
PASS: TestAccComputeFleet_virtualMachineProfileNetwork_completeForAdditionalLocation (848.91s)
PASS: TestAccComputeFleet_virtualMachineProfileDataDisk_basic (360.75s)
PASS: TestAccComputeFleet_virtualMachineProfileDataDisk_complete (469.06s)
PASS: TestAccComputeFleet_virtualMachineProfileDataDisk_update (1296.47s)

Change Log

Below please provide what should go into the changelog (if anything) conforming to the Changelog Format documented here.

azurerm_compute_fleet - new resource

This is a (please select all that apply):

Bug Fix
New Feature (ie adding a service, resource, or data source)
Enhancement
Breaking Change

ms-zhenhua

Hi @sinbai ,

Thanks for this PR - I've taken a look through and left some comments. If we can fix those up, this should be good to go 👍

ms-zhenhua · 2025-02-17T02:33:03Z

+			ForceNew: true,
+		},
+
+		"vm_attributes": vmAttributesSchema(),


shall we define the schema inline as it's not reused in other places?

ms-zhenhua · 2025-02-17T02:52:18Z

+						Optional: true,
+						ForceNew: true,
+						Default:  string(fleets.RegularPriorityAllocationStrategyLowestPrice),
+						ValidateFunc: validation.StringInSlice([]string{


is there a PossibleValuesFor... method for this enum?

ms-zhenhua · 2025-02-17T02:53:08Z

+						Optional: true,
+						ForceNew: true,
+						Default:  string(fleets.SpotAllocationStrategyPriceCapacityOptimized),
+						ValidateFunc: validation.StringInSlice([]string{


is there a PossibleValuesFor... method for this enum?

ms-zhenhua · 2025-02-17T02:53:23Z

+						Optional: true,
+						ForceNew: true,
+						Default:  string(fleets.EvictionPolicyDelete),
+						ValidateFunc: validation.StringInSlice([]string{


is there a PossibleValuesFor... method for this enum?

ms-zhenhua · 2025-02-17T06:02:01Z

+					}
+				}
+
+				if a := model.AdditionalLocationProfile; len(a) > 0 && len(a[0].VirtualMachineProfileOverride) > 0 {


Suggested change

if a := model.AdditionalLocationProfile; len(a) > 0 && len(a[0].VirtualMachineProfileOverride) > 0 {

if additionalLocationProfile := model.AdditionalLocationProfile; len(additionalLocationProfile) > 0 && len(additionalLocationProfile[0].VirtualMachineProfileOverride) > 0 {

ms-zhenhua · 2025-02-20T03:01:20Z

+
+* `additional_unattend_content` - (Optional) One or more `additional_unattend_content` blocks as defined above.
+
+* `automatic_updates_enabled` - (Optional) Should the automatic updates of the virtual machines be enabled? Defaults to `true`.


Suggested change

* `automatic_updates_enabled` - (Optional) Should the automatic updates of the virtual machines be enabled? Defaults to `true`.

* `automatic_updates_enabled` - (Optional) Whether to enable the automatic updates of the virtual machines. Defaults to `true`.

ms-zhenhua · 2025-02-20T03:10:39Z

+
+* `automatic_updates_enabled` - (Optional) Should the automatic updates of the virtual machines be enabled? Defaults to `true`.
+
+* `bypass_platform_safety_checks_enabled` - (Optional) Should the customer to schedule patching without accidental upgrades be enabled? Defaults to `false`.


same as linux_configuration

ms-zhenhua · 2025-02-20T03:12:15Z

+
+* `bypass_platform_safety_checks_enabled` - (Optional) Should the customer to schedule patching without accidental upgrades be enabled? Defaults to `false`.
+
+* `hot_patching_enabled` - (Optional) Should the customers to patch the virtual machines without requiring a reboot be enabled? Defaults to `false`.


Suggested change

* `hot_patching_enabled` - (Optional) Should the customers to patch the virtual machines without requiring a reboot be enabled? Defaults to `false`.

* `hot_patching_enabled` - (Optional) Whether to enable the customers to patch the virtual machines without requiring a reboot. Defaults to `false`.

ms-zhenhua · 2025-02-20T03:12:52Z

+
+* `patch_mode` - (Optional)  Specifies the mode of in-guest patching of the virtual machines. Possible values are `AutomaticByOS`, `AutomaticByPlatform` and `Manual`.
+
+* `provision_vm_agent_enabled` - (Optional) Should the virtual machine agent be provisioned on each virtual machine in the Scale Set? Defaults to `true`.


same as linux_configuration

ms-zhenhua · 2025-02-20T03:13:26Z

+
+* `time_zone` - (Optional) Specifies the time zone of the windows virtual machine. Changing this forces a new resource to be created.
+
+* `vm_agent_platform_updates_enabled` - (Optional) Should the virtual machine agent platform updates be enabled for the windows virtual machine? Defaults to `false`.


same as linux_configuration

wyattfry · 2025-10-02T16:53:25Z

+	"github.com/hashicorp/terraform-provider-azurerm/utils"
+)
+
+func virtualMachineProfileSchema() *pluginsdk.Schema {


Could this schema be moved into the rest of the explicit definition? It seems this function is only called once.

wyattfry · 2025-10-02T19:57:16Z

+
+* `provision_vm_agent_enabled` - (Optional) Whether to provision the virtual machine agent on each virtual machine in the Scale Set. Defaults to `true`. Changing this forces a new resource to be created.
+
+* `reboot_setting` - (Optional) Specifies the reboot setting for all `AutomaticByPlatform` patch installation operations. Possible values are `Always`, `IfRequired`, `Never` and `Unknown`. Changing this forces a new resource to be created.


Suggested change

* `reboot_setting` - (Optional) Specifies the reboot setting for all `AutomaticByPlatform` patch installation operations. Possible values are `Always`, `IfRequired`, `Never` and `Unknown`. Changing this forces a new resource to be created.

* `patch_rebooting` - (Optional) Specifies the reboot setting for all `AutomaticByPlatform` patch installation operations. Possible values are `Always`, `IfRequired`, `Never` and `Unknown`. Changing this forces a new resource to be created.

wyattfry · 2025-10-02T20:27:17Z

+
+* `plan` - (Optional) A `plan` block as defined below. Changing this forces a new resource to be created.
+
+* `platform_fault_domain_count` - (Optional)  Specifies the number of fault domains that are used by the Compute Fleet. Defaults to `1`. Changing this forces a new resource to be created.


Suggested change

* `platform_fault_domain_count` - (Optional) Specifies the number of fault domains that are used by the Compute Fleet. Defaults to `1`. Changing this forces a new resource to be created.

* `platform_fault_domain_count` - (Optional) Specifies the number of fault domains that are used by the Compute Fleet. Defaults to `1`. Changing this forces a new resource to be created.

wyattfry · 2025-10-02T20:27:47Z

+* `spot_priority_profile` - (Optional) A `spot_priority_profile` block as defined below.
+
+* `tags` - (Optional) A mapping of tags which should be assigned to the Compute Fleet.
+* 


Suggested change

*

wyattfry · 2025-10-02T20:28:14Z

+
+* `extension` - (Optional) One or more `extension` blocks as defined above. Changing this forces a new resource to be created.
+
+* `extension_operations_enabled` - (Optional) Whether to enable extension operations on the Compute Fleet.  Defaults to `true`. Changing this forces a new resource to be created.


Suggested change

* `extension_operations_enabled` - (Optional) Whether to enable extension operations on the Compute Fleet. Defaults to `true`. Changing this forces a new resource to be created.

* `extension_operations_enabled` - (Optional) Whether to enable extension operations on the Compute Fleet. Defaults to `true`. Changing this forces a new resource to be created.

wyattfry · 2025-10-02T20:28:41Z

+
+A `network_interface` block supports the following:
+
+* `name` - (Required)  The name which should be used for the network interface. Changing this forces a new resource to be created.


Suggested change

* `name` - (Required) The name which should be used for the network interface. Changing this forces a new resource to be created.

* `name` - (Required) The name which should be used for the network interface. Changing this forces a new resource to be created.

wyattfry · 2025-10-02T20:29:16Z

+
+A `additional_capabilities` block supports the following:
+
+* `hibernation_enabled` - (Optional) Whether to enable the hibernation capability on the Compute Fleet.  Defaults to `false`. Changing this forces a new resource to be created.


Suggested change

* `hibernation_enabled` - (Optional) Whether to enable the hibernation capability on the Compute Fleet. Defaults to `false`. Changing this forces a new resource to be created.

* `hibernation_enabled` - (Optional) Whether to enable the hibernation capability on the Compute Fleet. Defaults to `false`. Changing this forces a new resource to be created.

wyattfry · 2025-10-02T20:32:28Z

+
+* `disk_encryption_set_id` - (Optional) The ID of the disk encryption set which should be used to encrypt the data disk. Changing this forces a new resource to be created.
+
+* `disk_size_in_gib` - (Optional) The size of the data disk which should be created.  Changing this forces a new resource to be created.


Maybe indicate the unit once more in the description to emphasize the differentiation from GB?

Suggested change

* `disk_size_in_gib` - (Optional) The size of the data disk which should be created. Changing this forces a new resource to be created.

* `disk_size_in_gib` - (Optional) The size of the data disk which should be created in GiB. Changing this forces a new resource to be created.

wyattfry · 2025-10-02T20:33:01Z

+
+-> **Note:** Required if `create_option` is specified as `Empty`.
+
+* `storage_account_type` - (Optional)  The type of storage account which should back the data disk. Possible values include `Premium_LRS`, `PremiumV2_LRS`, `Premium_ZRS`, `Standard_LRS`, `StandardSSD_LRS`, `StandardSSD_ZRS` and `UltraSSD_LRS`. Changing this forces a new resource to be created.


Suggested change

* `storage_account_type` - (Optional) The type of storage account which should back the data disk. Possible values include `Premium_LRS`, `PremiumV2_LRS`, `Premium_ZRS`, `Standard_LRS`, `StandardSSD_LRS`, `StandardSSD_ZRS` and `UltraSSD_LRS`. Changing this forces a new resource to be created.

* `storage_account_type` - (Optional) The type of storage account which should back the data disk. Possible values include `Premium_LRS`, `PremiumV2_LRS`, `Premium_ZRS`, `Standard_LRS`, `StandardSSD_LRS`, `StandardSSD_ZRS` and `UltraSSD_LRS`. Changing this forces a new resource to be created.

wyattfry · 2025-10-02T20:33:48Z

+
+A `identity` block supports the following:
+
+* `type` - (Required)  The type of managed identity that should be configured on the Compute Fleet. The only possible value is `UserAssigned`.


Suggested change

* `type` - (Required) The type of managed identity that should be configured on the Compute Fleet. The only possible value is `UserAssigned`.

* `type` - (Required) The type of managed identity that should be configured on the Compute Fleet. The only possible value is `UserAssigned`.

wyattfry · 2025-10-02T20:35:22Z

+
+* `hot_patching_enabled` - (Optional) Whether to enable the customers to patch the virtual machines without requiring a reboot. Defaults to `false`. Changing this forces a new resource to be created.
+
+* `patch_mode` - (Optional)  Specifies the mode of in-guest patching of the virtual machines. Possible values are `AutomaticByOS`, `AutomaticByPlatform` and `Manual`. Changing this forces a new resource to be created.


Suggested change

* `patch_mode` - (Optional) Specifies the mode of in-guest patching of the virtual machines. Possible values are `AutomaticByOS`, `AutomaticByPlatform` and `Manual`. Changing this forces a new resource to be created.

* `patch_mode` - (Optional) Specifies the mode of in-guest patching of the virtual machines. Possible values are `AutomaticByOS`, `AutomaticByPlatform` and `Manual`. Changing this forces a new resource to be created.

wyattfry · 2025-10-02T20:36:06Z

+
+* `vm_agent_platform_updates_enabled` - (Optional) Whether to enable the virtual machine agent platform updates for the windows virtual machine in the Compute Fleet. Defaults to `false`. Changing this forces a new resource to be created.
+
+* `winrm_listener` - (Optional) One or more `winrm_listener` blocks as defined below.  Changing this forces a new resource to be created.


Suggested change

* `winrm_listener` - (Optional) One or more `winrm_listener` blocks as defined below. Changing this forces a new resource to be created.

* `winrm_listener` - (Optional) One or more `winrm_listener` blocks as defined below. Changing this forces a new resource to be created.

wyattfry · 2025-10-02T20:41:51Z

@@ -0,0 +1,37 @@
+package computefleet


Suggested change

package computefleet

// Copyright (c) HashiCorp, Inc.

// SPDX-License-Identifier: MPL-2.0

package computefleet

wyattfry · 2025-10-02T21:06:03Z

+
+			if len(state.SpotPriorityProfile) > 0 && len(state.RegularPriorityProfile) > 0 {
+				if state.SpotPriorityProfile[0].Capacity+state.RegularPriorityProfile[0].Capacity > 10000 {
+					return fmt.Errorf("the sum of `spot_priority_profile.0.capacity` and `regular_priority_profile.0.capacity` must be between `0` and `10000`, inclusive")


When not using a format string for an error message, you can simplify and use errors.New() (make sure to import errors)

Suggested change

return fmt.Errorf("the sum of `spot_priority_profile.0.capacity` and `regular_priority_profile.0.capacity` must be between `0` and `10000`, inclusive")

return errors.New("the sum of `spot_priority_profile.0.capacity` and `regular_priority_profile.0.capacity` must be between `0` and `10000`, inclusive")

wyattfry · 2025-10-02T21:06:18Z

+			if len(state.SpotPriorityProfile) > 0 {
+				if state.SpotPriorityProfile[0].MaintainCapacityEnabled {
+					if state.SpotPriorityProfile[0].MinCapacity > 0 {
+						return fmt.Errorf("`spot_priority_profile.0.min_capacity` is unable to be specified if `spot_priority_profile.0.maintain_enabled` is enabled")


Suggested change

return fmt.Errorf("`spot_priority_profile.0.min_capacity` is unable to be specified if `spot_priority_profile.0.maintain_enabled` is enabled")

return errors.New("`spot_priority_profile.0.min_capacity` is unable to be specified if `spot_priority_profile.0.maintain_enabled` is enabled")

wyattfry · 2025-10-02T21:06:29Z

+					}
+
+					if len(state.VMSizesProfile) < 3 {
+						return fmt.Errorf("`vm_sizes_profile` must be at least 3 Vm sizes if `spot_priority_profile.0.maintain_enabled` is enabled")


Suggested change

return fmt.Errorf("`vm_sizes_profile` must be at least 3 Vm sizes if `spot_priority_profile.0.maintain_enabled` is enabled")

return errors.New("`vm_sizes_profile` must be at least 3 Vm sizes if `spot_priority_profile.0.maintain_enabled` is enabled")

wyattfry · 2025-10-02T21:06:42Z

+					}
+
+					if len(state.Zones) == 0 {
+						return fmt.Errorf("enabling `spot_priority_profile.0.maintain_enabled` requires all qualified availability zones in the region to be supported")


Suggested change

return fmt.Errorf("enabling `spot_priority_profile.0.maintain_enabled` requires all qualified availability zones in the region to be supported")

return errors.New("enabling `spot_priority_profile.0.maintain_enabled` requires all qualified availability zones in the region to be supported")

wyattfry · 2025-10-02T21:06:59Z

+				}
+
+				if state.SpotPriorityProfile[0].MinCapacity > state.SpotPriorityProfile[0].Capacity {
+					return fmt.Errorf("`spot_priority_profile.0.min_capacity` must be between `0` and `spot_priority_profile.0.capacity`, inclusive")


Suggested change

return fmt.Errorf("`spot_priority_profile.0.min_capacity` must be between `0` and `spot_priority_profile.0.capacity`, inclusive")

return errors.New("`spot_priority_profile.0.min_capacity` must be between `0` and `spot_priority_profile.0.capacity`, inclusive")

wyattfry · 2025-10-02T21:07:14Z

+
+			if len(state.RegularPriorityProfile) > 0 {
+				if state.RegularPriorityProfile[0].MinCapacity > state.RegularPriorityProfile[0].Capacity {
+					return fmt.Errorf("`RegularPriorityProfile.0.min_capacity` must be between `0` and `RegularPriorityProfile.0.capacity`, inclusive")


Suggested change

return fmt.Errorf("`RegularPriorityProfile.0.min_capacity` must be between `0` and `RegularPriorityProfile.0.capacity`, inclusive")

return errors.New("`RegularPriorityProfile.0.min_capacity` must be between `0` and `RegularPriorityProfile.0.capacity`, inclusive")

wyattfry · 2025-10-02T21:07:42Z

+				}
+
+				if !ultraSSDEnabled && storageAccountType == string(fleets.StorageAccountTypesUltraSSDLRS) {
+					return fmt.Errorf("`UltraSSD_LRS` storage account type can be used only when `ultra_ssd_enabled` is enalbed")


Suggested change

return fmt.Errorf("`UltraSSD_LRS` storage account type can be used only when `ultra_ssd_enabled` is enalbed")

return errors.New("`UltraSSD_LRS` storage account type can be used only when `ultra_ssd_enabled` is enabled")

wyattfry · 2025-10-02T21:08:07Z

+
+				if v[0].CreateOption == string(fleets.DiskCreateOptionTypesEmpty) {
+					if v[0].DiskSizeInGiB == 0 {
+						return fmt.Errorf("`disk_size_in_gib` is required when`create_option` is `Empty`")


Suggested change

return fmt.Errorf("`disk_size_in_gib` is required when`create_option` is `Empty`")

return errors.New("`disk_size_in_gib` is required when`create_option` is `Empty`")

wyattfry · 2025-10-02T21:08:27Z

+
+					lunExist := metadata.ResourceDiff.GetRawConfig().AsValueMap()["virtual_machine_profile"].AsValueSlice()[0].AsValueMap()["data_disk"].AsValueSlice()[0].AsValueMap()["lun"]
+					if lunExist.IsNull() {
+						return fmt.Errorf("`lun` is required when`create_option` is `Empty`")


Suggested change

return fmt.Errorf("`lun` is required when`create_option` is `Empty`")

return errors.New("`lun` is required when`create_option` is `Empty`")

wyattfry · 2025-10-02T21:08:48Z

+
+			vmProfile := state.VirtualMachineProfile[0]
+			if vmProfile.SourceImageId != "" && len(vmProfile.SourceImageReference) > 0 {
+				return fmt.Errorf("only one of `source_image_id` and `source_image_reference` in `virtual_machine_profile` must be specified")


Suggested change

return fmt.Errorf("only one of `source_image_id` and `source_image_reference` in `virtual_machine_profile` must be specified")

return errors.New("only one of `source_image_id` and `source_image_reference` in `virtual_machine_profile` must be specified")

wyattfry · 2025-10-02T21:09:01Z

+
+			for _, v := range state.VirtualMachineProfile[0].Extension {
+				if v.ProtectedSettingsJson != "" && len(v.ProtectedSettingsFromKeyVault) > 0 {
+					return fmt.Errorf("`protected_settings_from_key_vault` cannot be used with `protected_settings_json`")


Suggested change

return fmt.Errorf("`protected_settings_from_key_vault` cannot be used with `protected_settings_json`")

return errors.New("`protected_settings_from_key_vault` cannot be used with `protected_settings_json`")

wyattfry · 2025-10-02T21:09:28Z

+			}
+
+			if len(state.Zones) > 0 && state.PlatformFaultDomainCount > 1 {
+				return fmt.Errorf("specifying `zones` is not allowed when `platform_fault_domain_count` higher than 1")


Suggested change

return fmt.Errorf("specifying `zones` is not allowed when `platform_fault_domain_count` higher than 1")

return errors.New("specifying `zones` is not allowed when `platform_fault_domain_count` higher than 1")

wyattfry

Hi @sinbai thanks for working on this eagerly awaited feature. I left some proposed changes for you.

sinbai · 2025-10-10T09:45:31Z

Hi @sinbai thanks for working on this eagerly awaited feature. I left some proposed changes for you.

Hi @wyattfry thanks for your feedback. I've addressed the comments, could you please take another look?

gerrytan · 2026-04-23T06:59:55Z

Work on this new resource will continue in #32174 as we no longer have permission to push into this branch.

github-actions Bot added documentation dependencies size/XL waiting-response labels Feb 12, 2025

sinbai force-pushed the computefleet/new_resource branch from 11921e3 to 9c5d809 Compare February 12, 2025 10:56

github-actions Bot added waiting-response and removed waiting-response labels Feb 12, 2025

sinbai force-pushed the computefleet/new_resource branch from 9c5d809 to b18cc54 Compare February 12, 2025 11:52

github-actions Bot added waiting-response and removed waiting-response labels Feb 12, 2025

sinbai force-pushed the computefleet/new_resource branch from b18cc54 to 12b281e Compare February 13, 2025 01:31

github-actions Bot added waiting-response and removed waiting-response labels Feb 13, 2025

sinbai force-pushed the computefleet/new_resource branch from 12b281e to 16ace17 Compare February 13, 2025 01:51

github-actions Bot removed the waiting-response label Feb 13, 2025

ms-zhenhua suggested changes Feb 20, 2025

View reviewed changes

wyattfry reviewed Oct 2, 2025

View reviewed changes

wyattfry suggested changes Oct 2, 2025

View reviewed changes

fix comments

b099359

v-yhyeo0202 mentioned this pull request Apr 16, 2026

azurerm_compute_fleet - add new resource #32174

Draft

14 tasks

	if a := model.AdditionalLocationProfile; len(a) > 0 && len(a[0].VirtualMachineProfileOverride) > 0 {
	if additionalLocationProfile := model.AdditionalLocationProfile; len(additionalLocationProfile) > 0 && len(additionalLocationProfile[0].VirtualMachineProfileOverride) > 0 {


		* `additional_unattend_content` - (Optional) One or more `additional_unattend_content` blocks as defined above.

		* `automatic_updates_enabled` - (Optional) Should the automatic updates of the virtual machines be enabled? Defaults to `true`.


		* `automatic_updates_enabled` - (Optional) Should the automatic updates of the virtual machines be enabled? Defaults to `true`.

		* `bypass_platform_safety_checks_enabled` - (Optional) Should the customer to schedule patching without accidental upgrades be enabled? Defaults to `false`.


		* `bypass_platform_safety_checks_enabled` - (Optional) Should the customer to schedule patching without accidental upgrades be enabled? Defaults to `false`.

		* `hot_patching_enabled` - (Optional) Should the customers to patch the virtual machines without requiring a reboot be enabled? Defaults to `false`.

	* `hot_patching_enabled` - (Optional) Should the customers to patch the virtual machines without requiring a reboot be enabled? Defaults to `false`.
	* `hot_patching_enabled` - (Optional) Whether to enable the customers to patch the virtual machines without requiring a reboot. Defaults to `false`.


		* `patch_mode` - (Optional) Specifies the mode of in-guest patching of the virtual machines. Possible values are `AutomaticByOS`, `AutomaticByPlatform` and `Manual`.

		* `provision_vm_agent_enabled` - (Optional) Should the virtual machine agent be provisioned on each virtual machine in the Scale Set? Defaults to `true`.


		* `time_zone` - (Optional) Specifies the time zone of the windows virtual machine. Changing this forces a new resource to be created.

		* `vm_agent_platform_updates_enabled` - (Optional) Should the virtual machine agent platform updates be enabled for the windows virtual machine? Defaults to `false`.


		* `provision_vm_agent_enabled` - (Optional) Whether to provision the virtual machine agent on each virtual machine in the Scale Set. Defaults to `true`. Changing this forces a new resource to be created.

		* `reboot_setting` - (Optional) Specifies the reboot setting for all `AutomaticByPlatform` patch installation operations. Possible values are `Always`, `IfRequired`, `Never` and `Unknown`. Changing this forces a new resource to be created.

	* `reboot_setting` - (Optional) Specifies the reboot setting for all `AutomaticByPlatform` patch installation operations. Possible values are `Always`, `IfRequired`, `Never` and `Unknown`. Changing this forces a new resource to be created.
	* `patch_rebooting` - (Optional) Specifies the reboot setting for all `AutomaticByPlatform` patch installation operations. Possible values are `Always`, `IfRequired`, `Never` and `Unknown`. Changing this forces a new resource to be created.


		* `plan` - (Optional) A `plan` block as defined below. Changing this forces a new resource to be created.

		* `platform_fault_domain_count` - (Optional) Specifies the number of fault domains that are used by the Compute Fleet. Defaults to `1`. Changing this forces a new resource to be created.


		* `extension` - (Optional) One or more `extension` blocks as defined above. Changing this forces a new resource to be created.

		* `extension_operations_enabled` - (Optional) Whether to enable extension operations on the Compute Fleet. Defaults to `true`. Changing this forces a new resource to be created.


		A `network_interface` block supports the following:

		* `name` - (Required) The name which should be used for the network interface. Changing this forces a new resource to be created.


		A `additional_capabilities` block supports the following:

		* `hibernation_enabled` - (Optional) Whether to enable the hibernation capability on the Compute Fleet. Defaults to `false`. Changing this forces a new resource to be created.


		* `disk_encryption_set_id` - (Optional) The ID of the disk encryption set which should be used to encrypt the data disk. Changing this forces a new resource to be created.

		* `disk_size_in_gib` - (Optional) The size of the data disk which should be created. Changing this forces a new resource to be created.


		-> Note: Required if `create_option` is specified as `Empty`.

		* `storage_account_type` - (Optional) The type of storage account which should back the data disk. Possible values include `Premium_LRS`, `PremiumV2_LRS`, `Premium_ZRS`, `Standard_LRS`, `StandardSSD_LRS`, `StandardSSD_ZRS` and `UltraSSD_LRS`. Changing this forces a new resource to be created.


		A `identity` block supports the following:

		* `type` - (Required) The type of managed identity that should be configured on the Compute Fleet. The only possible value is `UserAssigned`.


		* `vm_agent_platform_updates_enabled` - (Optional) Whether to enable the virtual machine agent platform updates for the windows virtual machine in the Compute Fleet. Defaults to `false`. Changing this forces a new resource to be created.

		* `winrm_listener` - (Optional) One or more `winrm_listener` blocks as defined below. Changing this forces a new resource to be created.

	return fmt.Errorf("the sum of `spot_priority_profile.0.capacity` and `regular_priority_profile.0.capacity` must be between `0` and `10000`, inclusive")
	return errors.New("the sum of `spot_priority_profile.0.capacity` and `regular_priority_profile.0.capacity` must be between `0` and `10000`, inclusive")

	return fmt.Errorf("`spot_priority_profile.0.min_capacity` is unable to be specified if `spot_priority_profile.0.maintain_enabled` is enabled")
	return errors.New("`spot_priority_profile.0.min_capacity` is unable to be specified if `spot_priority_profile.0.maintain_enabled` is enabled")

	return fmt.Errorf("`vm_sizes_profile` must be at least 3 Vm sizes if `spot_priority_profile.0.maintain_enabled` is enabled")
	return errors.New("`vm_sizes_profile` must be at least 3 Vm sizes if `spot_priority_profile.0.maintain_enabled` is enabled")

Conversation

sinbai commented Feb 12, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Community Note

Description

PR Checklist

Changes to existing Resource / Data Source

Testing

Change Log

Uh oh!

ms-zhenhua left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

sinbai commented Feb 12, 2025 •

edited

Loading

	return fmt.Errorf("enabling `spot_priority_profile.0.maintain_enabled` requires all qualified availability zones in the region to be supported")
	return errors.New("enabling `spot_priority_profile.0.maintain_enabled` requires all qualified availability zones in the region to be supported")

	return fmt.Errorf("`RegularPriorityProfile.0.min_capacity` must be between `0` and `RegularPriorityProfile.0.capacity`, inclusive")
	return errors.New("`RegularPriorityProfile.0.min_capacity` must be between `0` and `RegularPriorityProfile.0.capacity`, inclusive")

	return fmt.Errorf("`UltraSSD_LRS` storage account type can be used only when `ultra_ssd_enabled` is enalbed")
	return errors.New("`UltraSSD_LRS` storage account type can be used only when `ultra_ssd_enabled` is enabled")

	return fmt.Errorf("`disk_size_in_gib` is required when`create_option` is `Empty`")
	return errors.New("`disk_size_in_gib` is required when`create_option` is `Empty`")

	return fmt.Errorf("`lun` is required when`create_option` is `Empty`")
	return errors.New("`lun` is required when`create_option` is `Empty`")

	return fmt.Errorf("only one of `source_image_id` and `source_image_reference` in `virtual_machine_profile` must be specified")
	return errors.New("only one of `source_image_id` and `source_image_reference` in `virtual_machine_profile` must be specified")

	return fmt.Errorf("`protected_settings_from_key_vault` cannot be used with `protected_settings_json`")
	return errors.New("`protected_settings_from_key_vault` cannot be used with `protected_settings_json`")

	return fmt.Errorf("specifying `zones` is not allowed when `platform_fault_domain_count` higher than 1")
	return errors.New("specifying `zones` is not allowed when `platform_fault_domain_count` higher than 1")