Skip to content

resource/aws_msk_cluster: Correct vpc_connectivity state path in UpdateConnectivity#47515

Merged
ewbankkit merged 3 commits intohashicorp:mainfrom
geekahmed:b-aws_msk_cluster-connectivity-getok
Apr 20, 2026
Merged

resource/aws_msk_cluster: Correct vpc_connectivity state path in UpdateConnectivity#47515
ewbankkit merged 3 commits intohashicorp:mainfrom
geekahmed:b-aws_msk_cluster-connectivity-getok

Conversation

@geekahmed
Copy link
Copy Markdown
Contributor

@geekahmed geekahmed commented Apr 17, 2026 •
edited
Loading

aws_msk_cluster update logic had a typo in the Terraform state path used by GetOk: it used ...0,vpc_connectivity (comma) instead of ...0.vpc_connectivity (dot).
Because of that, GetOk could not read vpc_connectivity from state, so VPC connectivity changes might be skipped during updates.

The fix changes the path to the correct dotted form so GetOk matches HasChange and VPC connectivity settings are correctly included in UpdateConnectivity.

@geekahmed
Fix MSK cluster vpc_connectivity GetOk state path
c0f5ee3 
Use the correct dotted Terraform path for broker_node_group_info
connectivity_info vpc_connectivity so GetOk matches HasChange and
planned updates include VPC connectivity settings.
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Apr 17, 2026

Welcome @geekahmed 👋

It looks like this is your first Pull Request submission to the Terraform AWS Provider repository. Thank you very much for taking the time to do so, and welcome to the community! 🎉

Community Guidelines

This comment is added to every new Pull Request to provide quick reference to how the Terraform AWS Provider is maintained. Please review the information below, and thank you for contributing to the community that keeps the provider thriving! 🚀

Voting for Prioritization

  • Please vote on this Pull Request by adding a 👍 reaction to the original post to help the community and maintainers prioritize it.
  • Please see our prioritization guide for additional information on how the maintainers handle prioritization.
  • Please do not leave +1 or other comments that do not add relevant new information or questions; they generate extra noise for others following the Pull Request and do not help prioritize the request.

Pull Request Authors

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions Bot added needs-triage Waiting for first response or review from a maintainer. service/kafka Issues and PRs that pertain to the kafka service. size/XS Managed by automation to categorize the size of a PR. labels Apr 17, 2026
@geekahmed geekahmed marked this pull request as ready for review April 17, 2026 21:26
@geekahmed geekahmed requested a review from a team as a code owner April 17, 2026 21:26
@dosubot dosubot Bot added the bug Addresses a defect in current functionality. label Apr 17, 2026
@tabito-hara
Copy link
Copy Markdown
Contributor

tabito-hara commented Apr 17, 2026

Oops…
It’s a terrible typo in my PR #47279 .
Thank you very much for your fix.

@geekahmed
Copy link
Copy Markdown
Contributor Author

geekahmed commented Apr 17, 2026

Oops… It’s a terrible typo in my PR #47279 . Thank you very much for your fix.

No problem. Actually because of this typo the vpc connectivity is always empty object and gives request params error. Using version 6.39.0, this error is not existing.

@jar-b jar-b removed the needs-triage Waiting for first response or review from a maintainer. label Apr 18, 2026
@tabito-hara
Copy link
Copy Markdown
Contributor

tabito-hara commented Apr 18, 2026

In addition to the typo, it was my oversight not to include an acceptance test for updating vpc_connectivity, even though the update logic was modified.
After this PR is merged, I will add an acceptance test to cover this.

tabito-hara
tabito-hara reviewed Apr 18, 2026
View reviewed changes
Comment thread .changelog/47515.txt Outdated
@geekahmed @tabito-hara
Update .changelog/47515.txt
365bbeb 
Co-authored-by: Tabito Hara <105637744+tabito-hara@users.noreply.github.com>
ewbankkit
ewbankkit approved these changes Apr 20, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

@ewbankkit
Copy link
Copy Markdown
Contributor

ewbankkit commented Apr 20, 2026

@geekahmed Thanks for the contribution 🎉 👏.

@ewbankkit ewbankkit merged commit ac75cbc into hashicorp:main Apr 20, 2026
40 checks passed
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Apr 20, 2026

Warning

This Issue has been closed, meaning that any additional comments are much easier for the maintainers to miss. Please assume that the maintainers will not see them.

Ongoing conversations amongst community members are welcome, however, the issue will be locked after 30 days. Moving conversations to another venue, such as the AWS Provider forum, is recommended. If you have additional concerns, please open a new issue, referencing this one where needed.

@github-actions github-actions Bot added this to the v6.42.0 milestone Apr 20, 2026
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Apr 23, 2026

This functionality has been released in v6.42.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ewbankkit ewbankkit ewbankkit approved these changes

+1 more reviewer

@tabito-hara tabito-hara tabito-hara left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

bug Addresses a defect in current functionality. service/kafka Issues and PRs that pertain to the kafka service. size/XS Managed by automation to categorize the size of a PR.

Projects

None yet

Milestone

v6.42.0

Development

Successfully merging this pull request may close these issues.

4 participants

@geekahmed @tabito-hara @ewbankkit @jar-b