budgets: normalize limit_amount to avoid scientific notation breaking UpdateBudget#47501
Open
CorinneVerheyde wants to merge 2 commits intohashicorp:mainfrom
Open
Conversation
Contributor
Community GuidelinesThis comment is added to every new Pull Request to provide quick reference to how the Terraform AWS Provider is maintained. Please review the information below, and thank you for contributing to the community that keeps the provider thriving! 🚀 Voting for Prioritization
Pull Request Authors
|
Contributor
|
✅ Thank you for correcting the previously detected issues! The maintainers appreciate your efforts to make the review process as smooth as possible. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rollback Plan
Revert this change and publish a new provider release.
As this change only normalizes
limit_amountwhen readingaws_budgets_budget, rollback risk is low and isolated to the Budgets resource.Changes to Security Controls
No.
Description
Large
limit_amountvalues are returned by the AWS Budgets API in scientific notation (e.g.2.51E+7).The provider stores this value directly in state during Read:
This causes subsequent UpdateBudget calls to fail with:
This change normalizes limit_amount to a plain decimal string during Read, so subsequent updates continue to send a valid value to AWS.
An acceptance test
TestAccBudgetsBudget_largeLimitAmountUpdatewas added to reproduce the issue:Before fix: fails on update
After fix: passes
Relations
Closes #47487
References
Output from Acceptance Testing