Skip to content

docs/route53_records_exclusive: ChangeResourceRecordSets AWS API limits#47497

Open
oycyc wants to merge 3 commits intohashicorp:mainfrom
oycyc:d-route53-records-exclusive-api-limits
Open

docs/route53_records_exclusive: ChangeResourceRecordSets AWS API limits#47497
oycyc wants to merge 3 commits intohashicorp:mainfrom
oycyc:d-route53-records-exclusive-api-limits

Conversation

@oycyc
Copy link
Copy Markdown
Contributor

@oycyc oycyc commented Apr 16, 2026

Description

The aws_route53_records_exclusive resource batches every diffed change (CREATE/DELETE/UPSERT) from an apply into a single ChangeResourceRecordSets request. The provider does not split changes across multiple requests, so applies that exceed the AWS per-request limit fail at apply time with no automatic retry or chunking.

The AWS limit is 1,000 ResourceRecord elements per request, and UPSERT actions count each element twice — meaning modifications hit the cap at ~500 records. This was previously undocumented, so users managing larger hosted zones could hit unexpected failures on initial creates or bulk updates.

This PR adds a callout to the resource documentation covering:

  • The single-request behavior (no chunking).
  • The 1,000 element cap and UPSERT double-count rule.
  • A link to the AWS Route 53 API request limits documentation.
  • Worked examples distinguishing steady-state operation from failure cases (initial bulk create, large UPSERT batches).

No code changes.

References

Output from Acceptance Testing

N/A — documentation only.

…uest limits

The aws_route53_records_exclusive resource sends all diffed changes in a
single ChangeResourceRecordSets request with no chunking. Add a note to
the resource documentation explaining the 1,000 ResourceRecord element
per-request limit, the UPSERT double-count rule, and worked examples so
users can anticipate apply-time failures on large hosted zones.
@oycyc oycyc requested a review from a team as a code owner April 16, 2026 18:41
@github-actions
Copy link
Copy Markdown
Contributor

Community Guidelines

This comment is added to every new Pull Request to provide quick reference to how the Terraform AWS Provider is maintained. Please review the information below, and thank you for contributing to the community that keeps the provider thriving! 🚀

Voting for Prioritization

  • Please vote on this Pull Request by adding a 👍 reaction to the original post to help the community and maintainers prioritize it.
  • Please see our prioritization guide for additional information on how the maintainers handle prioritization.
  • Please do not leave +1 or other comments that do not add relevant new information or questions; they generate extra noise for others following the Pull Request and do not help prioritize the request.

Pull Request Authors

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions Bot added needs-triage Waiting for first response or review from a maintainer. documentation Introduces or discusses updates to documentation. service/route53 Issues and PRs that pertain to the route53 service. size/XS Managed by automation to categorize the size of a PR. labels Apr 16, 2026
Comment thread website/docs/r/route53_records_exclusive.html.markdown Outdated
@justinretzolk justinretzolk added the waiting-response Maintainers are waiting on response from community or contributor. label Apr 16, 2026
Co-authored-by: Justin Retzolk <44710313+justinretzolk@users.noreply.github.com>
@oycyc oycyc requested a review from justinretzolk April 16, 2026 20:06
Comment thread website/docs/r/route53_records_exclusive.html.markdown Outdated
@oycyc
Copy link
Copy Markdown
Contributor Author

oycyc commented Apr 16, 2026

@justinretzolk updated PR accordingly, thanks for feedback

@github-actions github-actions Bot removed the waiting-response Maintainers are waiting on response from community or contributor. label Apr 16, 2026
@ewbankkit ewbankkit removed the needs-triage Waiting for first response or review from a maintainer. label Apr 17, 2026
@ewbankkit
Copy link
Copy Markdown
Contributor

@oycyc Thanks for the contribution 👏.
I'm going to merge this one and also create a new issue to capture that this is really a bug in the resource implementation; it is the provider's job to work with those API limits, not error out 😄.

Copy link
Copy Markdown
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Introduces or discusses updates to documentation. service/route53 Issues and PRs that pertain to the route53 service. size/XS Managed by automation to categorize the size of a PR.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants