fix: suppress perpetual diff for cloudwatch_logging_options when disabled

[yosofbadr]

Summary

Fixes #40446

When cloudwatch_logging_options.enabled is false on an aws_kinesis_firehose_delivery_stream, the AWS API returns empty strings for log_group_name and log_stream_name. If the user specifies values for these fields in their configuration (which is common -- they may toggle logging on/off via a variable), Terraform detects a diff on every plan and continually reapplies the same settings.

This PR adds a DiffSuppressFunc to both log_group_name and log_stream_name within the cloudwatch_logging_options schema. When the sibling enabled field is false, diffs on these fields are suppressed. This follows the same pattern used in the Athena workgroup resource (diffSuppressWorkGroupConfigurationMonitoringCloudWatchLogging).

The fix applies to all destination types that use cloudwatch_logging_options (Elasticsearch, Extended S3, HTTP Endpoint, Iceberg, OpenSearch, OpenSearch Serverless, Redshift, Snowflake, Splunk) since they all share the same cloudWatchLoggingOptionsSchema() function.

Changes

• internal/service/firehose/delivery_stream.go: Added diffSuppressCloudWatchLoggingOptionsDisabled function and wired it as DiffSuppressFunc on log_group_name and log_stream_name fields.

Test plan

• Verify go build ./internal/service/firehose/ passes
• Verify go vet ./internal/service/firehose/ passes
• Create a Firehose delivery stream with cloudwatch_logging_options where enabled = false and log_group_name/log_stream_name are set
• Run terraform plan and confirm no diff is detected
• Toggle enabled = true, apply, then set enabled = false again and confirm no perpetual diff
• Run existing acceptance tests: go test ./internal/service/firehose/ -run TestAcc

[github-actions]

Community Guidelines

This comment is added to every new Pull Request to provide quick reference to how the Terraform AWS Provider is maintained. Please review the information below, and thank you for contributing to the community that keeps the provider thriving! 🚀

Voting for Prioritization

• Please vote on this Pull Request by adding a 👍 reaction to the original post to help the community and maintainers prioritize it.
• Please see our prioritization guide for additional information on how the maintainers handle prioritization.
• Please do not leave +1 or other comments that do not add relevant new information or questions; they generate extra noise for others following the Pull Request and do not help prioritize the request.

Pull Request Authors

• Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
• Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

[github-actions]

✅ Thank you for correcting the previously detected issues! The maintainers appreciate your efforts to make the review process as smooth as possible.