redshift: treat Maintenance as pending during cluster create#47460
Open
faridnsh wants to merge 1 commit intohashicorp:mainfrom
Open
redshift: treat Maintenance as pending during cluster create#47460faridnsh wants to merge 1 commit intohashicorp:mainfrom
faridnsh wants to merge 1 commit intohashicorp:mainfrom
Conversation
Contributor
Community GuidelinesThis comment is added to every new Pull Request to provide quick reference to how the Terraform AWS Provider is maintained. Please review the information below, and thank you for contributing to the community that keeps the provider thriving! 🚀 Voting for Prioritization
Pull Request Authors
|
Acceptance test TestAccRedshiftClusterSnapshot_Tags_ComputedTag_OnUpdate_add failed in Step 1/3 while creating the backing aws_redshift_cluster.test from internal/service/redshift/testdata/ClusterSnapshot/tags/main_gen.tf. Original error: Error: creating Redshift Cluster (tf-acc-test-8275424384619408802): waiting for completion: unexpected state 'Maintenance', wanted target 'Available'. last error: creating Amazon Redshift documents ClusterAvailabilityStatus values as Available, Unavailable, Maintenance, Modifying, and Failed in the Cluster API reference. AWS re:Post also describes Maintenance as a normal state while Redshift applies updates or performs system tasks. waitClusterCreated should therefore treat Maintenance as pending, matching the existing Redshift update and delete waiters. References: - https://docs.aws.amazon.com/redshift/latest/APIReference/API_Cluster.html - https://repost.aws/knowledge-center/redshift-cluster-status
f191691 to
6752c00
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rollback Plan
If a change needs to be reverted, we will publish an updated version of the library.
Changes to Security Controls
No
Description
Acceptance test TestAccRedshiftClusterSnapshot_Tags_ComputedTag_OnUpdate_add failed in Step 1/3 while creating the backing aws_redshift_cluster.test from internal/service/redshift/testdata/ClusterSnapshot/tags/main_gen.tf.
Original error:
Amazon Redshift documents ClusterAvailabilityStatus values as Available, Unavailable, Maintenance, Modifying, and Failed in the Cluster API reference. AWS re:Post also describes Maintenance as a normal state while Redshift applies updates or performs system tasks. waitClusterCreated should therefore treat Maintenance as pending, matching the existing Redshift update and delete waiters.
I'm not sure how I can force a maintenance state intentionally to have a test that breaks always without this change, so didn't add it. Normally in other software I would cover this with unit tests but somehow I don't see many around Redshift here so I guess there's a good reason for it so I didn't add unit tests either.
Relations
This error was originally found when I was running the acceptance tests for #47435.
References
Output from Acceptance Testing
I tried to run all the tests that create a cluster. The failed test cases are fixed in #47444
Output