fix: preserve service_password in aws_iam_service_specific_credential Read#47424
Open
vringar wants to merge 1 commit intohashicorp:mainfrom
Open
fix: preserve service_password in aws_iam_service_specific_credential Read#47424vringar wants to merge 1 commit intohashicorp:mainfrom
vringar wants to merge 1 commit intohashicorp:mainfrom
Conversation
Contributor
Community GuidelinesThis comment is added to every new Pull Request to provide quick reference to how the Terraform AWS Provider is maintained. Please review the information below, and thank you for contributing to the community that keeps the provider thriving! 🚀 Voting for Prioritization
Pull Request Authors
|
vringar
added a commit
to vringar/terraform-provider-aws
that referenced
this pull request
Apr 13, 2026
c6c6368 to
05c4b1b
Compare
… Read ListServiceSpecificCredentials returns only metadata (no password), so resourceServiceSpecificCredentialRead never sets service_password. When Create calls Read inline before returning, the value set from the API response is cleared to "". Preserve the existing state value in Read so the password survives the implicit Read call after creation. Fixes hashicorp#47421
7007ea1 to
6cb512a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rollback Plan
If a change needs to be reverted, we will publish an updated version of the library.
Changes to Security Controls
No.
Description
service_passwordis always""in state afteraws_iam_service_specific_credentialis created.ReadusesListServiceSpecificCredentialswhich returns no password, so the value set byCreateis cleared before state is finalised. Preserve the existing state value inRead.Relations
Closes #47421
Output from Acceptance Testing
Unable to run acceptance tests (no funded AWS environment). Requesting maintainer run.