🤖🤖🤖 r/aws_redshift_custom_domain_association: Add resource & it's identity

[faridnsh]

Rollback Plan

If a change needs to be reverted, we will publish an updated version of the library.

Changes to Security Controls

No

Description

Adds aws_redshift_custom_domain_association for Amazon Redshift provisioned clusters.

The resource supports create, read, update, delete, import, Resource Identity, documentation, generated identity tests, and acceptance tests.

AI usage: Used an LLM coding agent to help implement the resource, tests, compare against existing Redshift Serverless patterns and also the code generated via skaff. I did it with Codex GPT 5.4 on xplus with AWS knowledge MCP so it can lookup the APIs.

I reviewed the resulting code, ran the acceptance tests and also used the compiled binary to do an end 2 end test with terraform binary to make sure it all works all manually myself.

Relations

Closes #35998
Relates #35865

References

https://docs.aws.amazon.com/redshift/latest/mgmt/connecting-connection-CNAME-connect.html

Output from Acceptance Testing

$ ACM_CERTIFICATE_ROOT_DOMAIN=faridnsh.ninja make testacc PKG=redshift TESTS='^TestAccRedshiftCustomDomainAssociation_' P=1
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
make: Running acceptance tests on branch: 🌿 f-redshift-custom-domain-association 🌿...
TF_ACC=1 go1.25.9 test ./internal/service/redshift/... -v -count 1 -parallel 1 -run='^TestAccRedshiftCustomDomainAssociation_'  -timeout 360m -vet=off
2026/04/11 22:14:25 Creating Terraform AWS Provider (SDKv2-style)...
2026/04/11 22:14:25 Initializing Terraform AWS Provider (SDKv2-style)...
=== RUN   TestAccRedshiftCustomDomainAssociation_Identity_basic
=== PAUSE TestAccRedshiftCustomDomainAssociation_Identity_basic
=== RUN   TestAccRedshiftCustomDomainAssociation_Identity_regionOverride
=== PAUSE TestAccRedshiftCustomDomainAssociation_Identity_regionOverride
=== RUN   TestAccRedshiftCustomDomainAssociation_basic
=== PAUSE TestAccRedshiftCustomDomainAssociation_basic
=== RUN   TestAccRedshiftCustomDomainAssociation_certificateARN
=== PAUSE TestAccRedshiftCustomDomainAssociation_certificateARN
=== RUN   TestAccRedshiftCustomDomainAssociation_disappears
=== PAUSE TestAccRedshiftCustomDomainAssociation_disappears
=== CONT  TestAccRedshiftCustomDomainAssociation_Identity_basic
--- PASS: TestAccRedshiftCustomDomainAssociation_Identity_basic (343.71s)
=== CONT  TestAccRedshiftCustomDomainAssociation_certificateARN
--- PASS: TestAccRedshiftCustomDomainAssociation_certificateARN (372.84s)
=== CONT  TestAccRedshiftCustomDomainAssociation_disappears
--- PASS: TestAccRedshiftCustomDomainAssociation_disappears (267.18s)
=== CONT  TestAccRedshiftCustomDomainAssociation_basic
--- PASS: TestAccRedshiftCustomDomainAssociation_basic (343.35s)
=== CONT  TestAccRedshiftCustomDomainAssociation_Identity_regionOverride
--- PASS: TestAccRedshiftCustomDomainAssociation_Identity_regionOverride (385.96s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/redshift	1726.776s...

[github-actions]

Community Guidelines

This comment is added to every new Pull Request to provide quick reference to how the Terraform AWS Provider is maintained. Please review the information below, and thank you for contributing to the community that keeps the provider thriving! 🚀

Voting for Prioritization

• Please vote on this Pull Request by adding a 👍 reaction to the original post to help the community and maintainers prioritize it.
• Please see our prioritization guide for additional information on how the maintainers handle prioritization.
• Please do not leave +1 or other comments that do not add relevant new information or questions; they generate extra noise for others following the Pull Request and do not help prioritize the request.

Pull Request Authors

• Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
• Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.