Skip to content

fix(structs): correct 'occured' -> 'occurred' in ACLTemplatedPolicy errors#23465

Closed
SAY-5 wants to merge 3 commits intohashicorp:mainfrom
SAY-5:fix-acl-templated-policy-occured-typo
Closed

fix(structs): correct 'occured' -> 'occurred' in ACLTemplatedPolicy errors#23465
SAY-5 wants to merge 3 commits intohashicorp:mainfrom
SAY-5:fix-acl-templated-policy-occured-typo

Conversation

@SAY-5
Copy link
Copy Markdown

@SAY-5 SAY-5 commented Apr 15, 2026

Two fmt.Errorf strings in agent/structs/acl_templated_policy.go used an error occured when instead of an error occurred when:

return "", fmt.Errorf("an error occured when parsing template structs: %w", err)               // line 262
return "", fmt.Errorf("an error occured when executing on templated policy variables: %w", err) // line 275

Both errors are wrapped and surfaced through the templated-policy parsing path, so the spelling is user-visible in API error responses. go build ./agent/structs/ stays clean against current main.

…rrors

Two fmt.Errorf strings in agent/structs/acl_templated_policy.go used
'an error occured when' instead of 'an error occurred when'. Both
errors are wrapped and surfaced through the templated-policy parsing
path, so the spelling is user-visible in API error responses. go build
on agent/structs stays clean.
@SAY-5 SAY-5 requested review from a team as code owners April 15, 2026 16:13
@hashicorp-cla-app
Copy link
Copy Markdown

hashicorp-cla-app Bot commented Apr 15, 2026

CLA assistant check

Thank you for your submission! We require that all contributors sign our Contributor License Agreement ("CLA") before we can accept the contribution. Read and sign the agreement

Learn more about why HashiCorp requires a CLA and what the CLA includes


1 out of 2 committers have signed the CLA.

  • panman90
  • SAY-5

SAY-5 seems not to be a GitHub user.
You need a GitHub account to be able to sign the CLA.
If you have already a GitHub account, please add the email address used for this commit to your account.

Have you signed the CLA already but the status is still pending? Recheck it.

@hashicorp-cla-app
Copy link
Copy Markdown

CLA assistant check

Thank you for your submission! We require that all contributors sign our Contributor License Agreement ("CLA") before we can accept the contribution. Read and sign the agreement

Learn more about why HashiCorp requires a CLA and what the CLA includes


SAY-5 seems not to be a GitHub user.
You need a GitHub account to be able to sign the CLA.
If you have already a GitHub account, please add the email address used for this commit to your account.

Have you signed the CLA already but the status is still pending? Recheck it.

Copy link
Copy Markdown
Contributor

@santoshpulluri santoshpulluri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes are related to fixing the typo in logs. Looks good.

@panman90 panman90 enabled auto-merge (squash) April 24, 2026 10:52
@panman90 panman90 added backport/2.0 Changes are backported to 2.0 backport/ent/2.0 Changes are backported to 2.0 ent labels Apr 24, 2026
@santoshpulluri santoshpulluri added backport/ent/1.21 changes are backported to 1.21 ent backport/ent/1.22 Changes are backported to 1.22 ent labels Apr 24, 2026
@panman90 panman90 added backport/1.22 Changes are backported to 1.22 backport/ent/1.22 Changes are backported to 1.22 ent and removed backport/ent/1.22 Changes are backported to 1.22 ent backport/1.22 Changes are backported to 1.22 labels Apr 24, 2026
@panman90 panman90 added the pr/no-changelog PR does not need a corresponding .changelog entry label Apr 24, 2026
@SAY-5
Copy link
Copy Markdown
Author

SAY-5 commented Apr 28, 2026

Closing — typo-only PR. Multiple maintainers across the OSS ecosystem have flagged my recent typo-sweep PRs as AI-generated spam (notably hashicorp/nomad#27855, hashicorp/hcl#794, argo-cd reviewers). I should have caught this pattern sooner. Apologies for the noise.

@SAY-5 SAY-5 closed this Apr 28, 2026
auto-merge was automatically disabled April 28, 2026 04:52

Pull request was closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport/ent/1.21 changes are backported to 1.21 ent backport/ent/1.22 Changes are backported to 1.22 ent backport/ent/2.0 Changes are backported to 2.0 ent backport/2.0 Changes are backported to 2.0 pr/no-changelog PR does not need a corresponding .changelog entry

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants