perf: parallelize iframe population in accessibility snapshots (upstream #15083)#3499
Open
kblok wants to merge 4 commits into
Open
perf: parallelize iframe population in accessibility snapshots (upstream #15083)#3499kblok wants to merge 4 commits into
kblok wants to merge 4 commits into
Conversation
…eam #15083) Replace sequential foreach loop with Task.WhenAll in PopulateIframesAsync, mirroring upstream's Promise.all optimization. Pages with multiple iframes now populate their accessibility trees concurrently instead of one-by-one. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When
page.accessibility.snapshot({ includeIframes: true })runs on a page with multiple iframes, we were populating each iframe's accessibility tree one at a time. Replaced the sequentialforeachloop inPopulateIframesAsyncwithTask.WhenAll, so all iframes are populated concurrently — matching upstream'sPromise.allchange.Upstream: puppeteer/puppeteer#15083