Remove restriction on extending property accessors and method resolvers#5
Open
JohnNiang wants to merge 1 commit into
Open
Remove restriction on extending property accessors and method resolvers#5JohnNiang wants to merge 1 commit into
JohnNiang wants to merge 1 commit into
Conversation
…n variable access is restricted Remove the restriction that prevented custom property accessors and method resolvers from being used when variableAccessRestricted is true. The variable access restriction is already enforced at the variable access level, so there is no security impact.
|
Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
f2c-ci-robot
Bot
added
the
do-not-merge/release-note-label-needed
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove the
variableAccessRestrictedcheck ingetMethodResolvers()andgetPropertyAccessors()so thatcustom property accessors and method resolvers can be added even when variable access restriction is enabled.
The variable access restriction is already enforced at the variable access level, so this change does not affect security.