Make some of the c.g.g.view.client.*SelectionModelTest tests async.#10365
Open
niloc132 wants to merge 1 commit into
Open
Make some of the c.g.g.view.client.*SelectionModelTest tests async.#10365niloc132 wants to merge 1 commit into
niloc132 wants to merge 1 commit into
Conversation
SelectionModel fires selection events using a finally command and some tests using SelectionChangeEvent.Handler were not async. In addition these tests had an implementation that let the test fail (but ANT never noticed because tests were sync). This CL makes sure all tests using SelectionChangeEvent.Handler are async and updates implementation slightly to correclty assert event behavior. Bug: gwtproject#9622 Bug-Link: gwtproject#9622 Change-Id: I66ba1170d2a1335d3ad921346017b5b5bc1accf8
niloc132
added
the
ready
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SelectionModel fires selection events using a finally command and some tests using SelectionChangeEvent.Handler were not async. In addition these tests had an implementation that let the test fail (but ANT never noticed because tests were sync).
This CL makes sure all tests using SelectionChangeEvent.Handler are async and updates implementation slightly to correclty assert event behavior.
Previously submitted as https://gwt-review.googlesource.com/c/gwt/+/21060.
Fixes #9622