Fix Javadoc issues, hide more Error Prone warnings

common.ant.xml

@@ -161,7 +161,7 @@
     <attribute name="release" default="${javac.release}" />
     <attribute name="excludes" default="" />
     <attribute name="processorpath" default="" />
-    <attribute name="errorprone.args" default="-XepDisableWarningsInGeneratedCode -Xep:MissingOverride:ERROR -Xep:UnrecognisedJavadocTag:OFF -Xep:InvalidBlockTag:OFF -Xep:AnnotateFormatMethod:OFF -Xep:ProtectedMembersInFinalClass:OFF -Xep:TypeParameterUnusedInFormals:OFF -Xep:InvalidLink:OFF -Xep:NotJavadoc:OFF -Xep:OperatorPrecedence:OFF -Xep:IdentityHashMapUsage:OFF -Xep:DefaultCharset:OFF -Xep:StringSplitter:OFF -Xep:BadImport:OFF -Xep:UnusedVariable:OFF -Xep:JdkObsolete:OFF -Xep:SameNameButDifferent:OFF -Xep:InlineMeSuggester:OFF -Xep:UnnecessaryParentheses:OFF -Xep:NonApiType:OFF -Xep:InvalidInlineTag:OFF -Xep:ReferenceEquality:OFF -Xep:JavaUtilDate:OFF -Xep:MissingSummary:OFF -Xep:EmptyBlockTag:OFF -Xep:BoxedPrimitiveConstructor:OFF -Xep:DateChecker:OFF" />
+    <attribute name="errorprone.args" default="-XepDisableWarningsInGeneratedCode -Xep:MissingOverride:ERROR -Xep:InvalidParam:ERROR -Xep:UnrecognisedJavadocTag:ERROR -Xep:InvalidBlockTag:OFF -Xep:AnnotateFormatMethod:OFF -Xep:ProtectedMembersInFinalClass:OFF -Xep:TypeParameterUnusedInFormals:OFF -Xep:InvalidLink:OFF -Xep:NotJavadoc:OFF -Xep:OperatorPrecedence:OFF -Xep:IdentityHashMapUsage:OFF -Xep:DefaultCharset:OFF -Xep:StringSplitter:OFF -Xep:BadImport:OFF -Xep:UnusedVariable:OFF -Xep:JdkObsolete:OFF -Xep:SameNameButDifferent:OFF -Xep:InlineMeSuggester:OFF -Xep:UnnecessaryParentheses:OFF -Xep:NonApiType:OFF -Xep:InvalidInlineTag:OFF -Xep:ReferenceEquality:OFF -Xep:JavaUtilDate:OFF -Xep:MissingSummary:OFF -Xep:EmptyBlockTag:OFF -Xep:BoxedPrimitiveConstructor:OFF -Xep:DateChecker:OFF -Xep:EffectivelyPrivate:OFF -Xep:PatternMatchingInstanceof:OFF -Xep:StatementSwitchToExpressionSwitch:OFF" />
     <element name="javaccontents" implicit="true" optional="true" />
 
     <sequential>

dev/codeserver/java/com/google/gwt/dev/codeserver/Pages.java

@@ -63,7 +63,7 @@ static class HtmlPage implements Response {
     final URL resource;
 
     /**
-     * @see {@link #newHtmlPage}.
+     * @see #newHtmlPage
      */
     private HtmlPage(String variableName, JsonObject json, URL resource) {
       this.variableName = variableName;

dev/core/src/com/google/gwt/dev/javac/CompiledClass.java

@@ -107,7 +107,7 @@ protected CompiledClass(CompiledClass enclosingClass,
    *          14.3)
    * @param internalName the internal binary name for this class. e.g.
    *          {@code java/util/Map$Entry}. See
-   *          {@link "http://java.sun.com/docs/books/jvms/second_edition/html/ClassFile.doc.html#14757"}
+   *          <a href="https://docs.oracle.com/javase/specs/jls/se25/html/jls-13.html#jls-13.1">JLS 13.1</a>.
    * @param sourceName the qualified source name, e.g. {@code java.util.Map.Entry}.
    */
   CompiledClass(byte[] classBytes, CompiledClass enclosingClass, boolean isLocal,

dev/core/src/com/google/gwt/dev/javac/MethodVisitor.java

@@ -86,10 +86,9 @@ public void endVisitValid(TypeDeclaration type, BlockScope scope) {
    * no name are not passed to this method, even if {@link #interestingMethod}
    * returns true.
    *
-   * @param typeDecl
-   * @param method
-   * @param enclosingType
-   * @param loc
+   * @param typeDecl type declaration
+   * @param method method
+   * @param enclosingType enclosing type
    */
   protected abstract void processMethod(TypeDeclaration typeDecl,
       AbstractMethodDeclaration method, String enclosingType);
@@ -98,8 +97,7 @@ protected abstract void processMethod(TypeDeclaration typeDecl,
    * Collect data about interesting methods on a particular type in a
    * compilation unit.
    *
-   * @param cud
-   * @param typeDecl
+   * @param typeDecl type declaration
    */
   private void collectMethods(TypeDeclaration typeDecl) {
     AbstractMethodDeclaration[] methods = typeDecl.methods;

dev/core/src/com/google/gwt/dev/jjs/ast/JMethodCall.java

@@ -208,17 +208,17 @@ public boolean isVolatile() {
   /**
    * Override the return type.
    * <p>
-   * The method call expression will have {@code overridentReturnType} as its type ignoring the
+   * The method call expression will have {@code overriddenReturnType} as its type ignoring the
    * return type of the target method. This is used during normalizing transformations to preserve
    * type semantics when calling externally-defined compiler implementation methods.
    * <p>
    * For example, Cast.dynamicCast() returns Object but that method is used to implement the cast
    * operation. Using a stronger type on the call expression allows us to preserve type information
    * during the latter phases of compilation.
    */
-  public void overrideReturnType(JType overridenReturnType) {
+  public void overrideReturnType(JType overriddenReturnType) {
     assert this.overriddenReturnType == null;
-    this.overriddenReturnType = overridenReturnType;
+    this.overriddenReturnType = overriddenReturnType;
   }
   /**
    * Resolve an external reference during AST stitching.

dev/core/src/com/google/gwt/dev/jjs/impl/Devirtualizer.java

@@ -353,7 +353,7 @@ public static void exec(JProgram program) {
 
   /**
    * Creates and empty devirtualized method for devirtualizing {@code method} in class
-   * {@code inclass}.
+   * {@code inClass}.
    */
   private JMethod createDevirtualMethodFor(JMethod method, JDeclaredType inClass) {
     SourceInfo sourceInfo = method.getSourceInfo().makeChild();

dev/core/src/com/google/gwt/dev/js/rhino/Context.java

@@ -382,7 +382,7 @@ public Locale setLocale(Locale loc) {
      * @see java.beans.PropertyChangeEvent
      * @param  property  the bound property
      * @param  oldValue  the old value
-     * @param  newVale   the new value
+     * @param  newValue   the new value
      */
     void firePropertyChange(String property, Object oldValue,
                             Object newValue)

dev/core/src/com/google/gwt/dev/shell/ShellJavaScriptHost.java

@@ -37,7 +37,6 @@ public interface ShellJavaScriptHost {
    * Define one or more JSNI methods.
    *
    * @param logger
-   * @param compiledClass
    * @param jsniMethods
    * @param dispatchIdOracle
    */

dev/core/src/com/google/gwt/dev/shell/remoteui/MessageTransport.java

@@ -218,8 +218,8 @@ public Response call() throws Exception {
    * @param outputStream an output stream for writing messages
    * @param requestProcessor a callback interface for handling remote client
    *          requests
-   * @param terminationCallback a callback that is invoked when the transport
-   *          terminates
+   * @param errorCallback a callback that is invoked when the transport
+   *          terminates or an error occurs
    */
   public MessageTransport(final InputStream inputStream,
       final OutputStream outputStream, RequestProcessor requestProcessor,

dev/core/src/com/google/gwt/dev/shell/rewrite/WriteJsoImpl.java

@@ -259,8 +259,6 @@ public static ClassVisitor create(ClassVisitor cv, String classDescriptor,
    * Construct a new rewriter instance.
    *
    * @param cv the visitor to chain to
-   * @param jsoDescriptors an unmodifiable set of descriptors containing
-   *          <code>JavaScriptObject</code> and all subclasses
    * @param mapper maps methods to the class in which they are declared
    */
   private WriteJsoImpl(ClassVisitor cv, InstanceMethodOracle mapper) {

dev/core/src/com/google/gwt/dev/util/Name.java

@@ -26,7 +26,7 @@ public class Name {
    * Represents a Java class name in binary form, for example:
    * {@code org.example.Foo$Bar}.
    *
-   * See {@link "http://java.sun.com/docs/books/jls/third_edition/html/binaryComp.html#59892"}
+   * See <a href="https://docs.oracle.com/javase/specs/jls/se25/html/jls-13.html#jls-13.1">JLS 13.1</a>
    */
   public static class BinaryName {
 
@@ -75,7 +75,7 @@ private BinaryName() {
      * Represents a Java class name in internal form, for example:
      * {@code org/example/Foo$Bar}.
      *
-     * See {@link "http://java.sun.com/docs/books/jvms/second_edition/html/ClassFile.doc.html#14757"}
+     * See <a href="https://docs.oracle.com/javase/specs/jls/se25/html/jls-13.html#jls-13.1">JLS 13.1</a>
      */
     public static class InternalName {
 
@@ -113,7 +113,7 @@ private InternalName() {
   /**
    * Represents a Java class name in source form, for example: {@code org.example.Foo.Bar}.
    *
-   * See {@link "http://java.sun.com/docs/books/jvms/second_edition/html/Concepts.doc.html#20207"}
+   * See <a href="https://docs.oracle.com/en/java/javase/25/docs/specs/jls/jls-6.html#jls-6.7">JLS 6.7</a>
    */
   public static class SourceName {
 
@@ -147,7 +147,7 @@ private SourceName() {
    * Represents a Java class name in either source or binary form, for example:
    * {@code org.example.Foo.Bar or org.example.Foo$Bar}.
    *
-   * See {@link "http://java.sun.com/docs/books/jls/third_edition/html/binaryComp.html#59892"}
+   * See <a href="https://docs.oracle.com/javase/specs/jls/se25/html/jls-13.html#jls-13.1">JLS 13.1</a>
    */
   public static class SourceOrBinaryName {
 

dev/core/src/com/google/gwt/dev/util/log/AbstractTreeLogger.java

@@ -334,7 +334,7 @@ public void setAmount(MetricName name, long amount) {
    * @param t a possibly null {@link Throwable}
    * @return true if {@link OutOfMemoryError} or {@link StackOverflowError}
    *         appears anywhere in the cause list or if <code>t</code> is an
-   *         {@link OutOfMemoryError} or {@link StackOverflowError.
+   *         {@link OutOfMemoryError} or {@link StackOverflowError}.
    */
   private String causedBySpecialError(Throwable t) {
     while (t != null) {

dev/core/src/com/google/gwt/soyc/MakeTopLevelHtmlForPerm.java

@@ -1426,8 +1426,8 @@ private String inferDepGraphDescription(String depGraphName) {
   /**
    * Returns whether a split point is initial or not.
    *
-   * @param splitPoint
-   * @returns true of the split point is initial, false otherwise
+   * @param splitPoint split point ID
+   * @return true of the split point is initial, false otherwise
    */
   private boolean isInitialSplitPoint(int splitPoint) {
     return globalInformation.getInitialFragmentLoadSequence().contains(

dev/core/super/com/google/gwt/lang/BigLongLibBase.java

@@ -21,7 +21,7 @@
  */
 class BigLongLibBase {
 
-  /*
+  /**
    * Implementation: A LongEmul containing three values {l, m, h} (low, middle,
    * high) such that (x.l + ((long) x.m << 22) + ((long) x.h << 44)) is equal to
    * the original long integer. The constant 22 is chosen since some browsers

dev/core/test/com/google/gwt/dev/shell/remoteui/MessageTransportTest.java

@@ -94,7 +94,6 @@ private static MockNetwork createMockNetwork() throws IOException {
    * Tests that sending an async request to a server when the server's socket is
    * closed with result in an ExecutionException on a call to future.get().
    *
-   * @throws ExecutionException
    * @throws InterruptedException
    * @throws IOException
    */
@@ -333,8 +332,6 @@ public void onTermination(Exception e) {
    * successfully received by the client.
    *
    * @throws IOException
-   * @throws ExecutionException
-   * @throws InterruptedException
    */
   public void testRequestProcessor() throws IOException {
     MockNetwork network = createMockNetwork();
@@ -408,8 +405,6 @@ public void onTermination(Exception e) {
    * passed back in the form of an error response to the client.
    *
    * @throws IOException
-   * @throws ExecutionException
-   * @throws InterruptedException
    */
   public void testRequestProcessorThrowsException() throws IOException {
     MockNetwork network = createMockNetwork();

user/src/com/google/gwt/aria/client/Attribute.java

@@ -86,7 +86,8 @@ public void remove(Element element) {
   }
 
   /**
-   * Sets the state/property {@code value} for the HTML element {@code element}.
+   * Sets the state/property for the HTML element {@code element}
+   * to space-separated list of {@code values}.
    *
    * @param element HTML element
    * @param values Attribute value

user/src/com/google/gwt/cell/client/AbstractInputCell.java

@@ -51,7 +51,7 @@ private static Set<String> getConsumedEventsImpl(Set<String> userEvents) {
   /**
    * Get the events consumed by the input cell.
    * 
-   * @param userEvents the events consumed by the subclass
+   * @param consumedEvents the events consumed by the subclass
    * @return the events
    */
   private static Set<String> getConsumedEventsImpl(String... consumedEvents) {

user/src/com/google/gwt/core/client/impl/AsyncFragmentLoader.java

@@ -289,7 +289,7 @@ public static void runAsync(int fragment, RunAsyncCallback callback) {
   /**
    * Creates the loader stored as {@link #BROWSER_LOADER}.
    * 
-   * @returns {@code null} if not in GWT client code, where
+   * @return {@code null} if not in GWT client code, where
    *          {@link GWT#create(Class)} cannot be used, or a fragment loader for
    *          the user's application otherwise.
    */

user/src/com/google/gwt/dom/client/MediaElement.java

@@ -21,7 +21,7 @@
 /**
  * Common superclass for Audio and Video elements.
  *
- * See {@link <a href="http://www.w3.org/TR/html5/video.html">W3C HTML5 Video and Audio</a>}
+ * See <a href="http://www.w3.org/TR/html5/video.html">W3C HTML5 Video and Audio</a>
  */
 public class MediaElement extends Element {
 

user/src/com/google/gwt/dom/client/Style.java

@@ -407,6 +407,7 @@ public String getCssName() {
   /**
    * Enum for the float property.
    */
+  @SuppressWarnings("JavaLangClash")
   public enum Float implements HasCssName {
     LEFT {
       @Override

user/src/com/google/gwt/dom/client/Touch.java

@@ -20,7 +20,7 @@
 /**
  * Class representing touches.
  *
- * See {@link <a href="http://developer.apple.com/library/safari/#documentation/UserExperience/Reference/TouchClassReference/Touch/Touch.html">Safari Touch Documentation</a>}
+ * See <a href="https://developer.apple.com/library/safari/#documentation/UserExperience/Reference/TouchClassReference/Touch/Touch.html">Safari Touch Documentation</a>.
  */
 public class Touch extends JavaScriptObject {
 

user/src/com/google/gwt/event/dom/client/TouchEvent.java

@@ -23,14 +23,14 @@
 /**
  * Abstract class representing touch events.
  *
- * See {@link <a href="http://developer.apple.com/library/safari/documentation/UserExperience/Reference/TouchEventClassReference/TouchEvent/TouchEvent.html">Safari Touch Event Documentation</a>}
+ * See <a href="https://developer.apple.com/library/safari/documentation/UserExperience/Reference/TouchEventClassReference/TouchEvent/TouchEvent.html">Safari Touch Event Documentation</a>.
  * @param <H> handler type
  */
 public abstract class TouchEvent<H extends EventHandler>
     extends HumanInputEvent<H> {
 
   /**
-   * Dectector for browser support for touch events.
+   * Detector for browser support for touch events.
    */
   private static class TouchSupportDetector {
 

user/src/com/google/gwt/http/client/RequestBuilder.java

@@ -360,9 +360,9 @@ public void setUser(String user) {
   }
 
   /**
-   * Sets whether the cross origin request will include credentials.
+   * Sets whether the cross-origin request will include credentials.
    *
-   * @param withCredentials whether to include credentials in XHR
+   * @param includeCredentials whether to include credentials in XHR
    */
   public void setIncludeCredentials(boolean includeCredentials) {
     this.includeCredentials = includeCredentials;

user/src/com/google/gwt/junit/JUnitMessageQueue.java

@@ -466,9 +466,9 @@ void waitForResults(int millis) {
   }
 
   /**
-   * Ensure that a {@link ClientStatus} for the clientId exists.
+   * Ensure that a {@link ClientStatus} for the given client exists.
    * 
-   * @param clientId the id of the client
+   * @param clientInfo contains the session ID of the client
    * @return the {@link ClientStatus} for the client
    */
   private ClientStatus ensureClientStatus(ClientInfoExt clientInfo) {

user/src/com/google/gwt/touch/client/Momentum.java

@@ -126,7 +126,7 @@ public void setVelocity(Point velocity) {
     /**
      * Set the cumulative elapsed time in milliseconds since momentum took over.
      * 
-     * @return the elapsed time in milliseconds
+     * @param cumulativeElapsedMillis the elapsed time in milliseconds
      */
     void setCumulativeElapsedMillis(int cumulativeElapsedMillis) {
       this.cumulativeElapsedMillis = cumulativeElapsedMillis;
@@ -136,7 +136,7 @@ void setCumulativeElapsedMillis(int cumulativeElapsedMillis) {
      * Set the elapsed time in milliseconds since the last time the state was
      * updated.
      * 
-     * @return the elapsed time
+     * @param elapsedMillis the elapsed time
      */
     void setElapsedMillis(int elapsedMillis) {
       this.elapsedMillis = elapsedMillis;

user/src/com/google/gwt/typedarrays/shared/ArrayBuffer.java

@@ -18,7 +18,7 @@
 /**
  * A buffer containing an arbitrary sequence of bytes.
  * 
- * {@link "http://www.khronos.org/registry/typedarray/specs/latest/#5"}
+ * @see <a href="https://262.ecma-international.org/6.0/#sec-typedarray-objects">typed array specification</a>
  */
 public interface ArrayBuffer {
 

user/src/com/google/gwt/typedarrays/shared/ArrayBufferView.java

@@ -18,7 +18,7 @@
 /**
  * Common information across all types of views of {@link ArrayBuffer}s.
  * 
- * {@link "http://www.khronos.org/registry/typedarray/specs/latest/#6"}
+ * @see <a href="https://262.ecma-international.org/6.0/#sec-typedarray-objects">typed array specification</a>
  */
 public interface ArrayBufferView {
 

user/src/com/google/gwt/typedarrays/shared/DataView.java

@@ -18,7 +18,7 @@
 /**
  * A view representing an {@link ArrayBuffer} as heterogeneous values.
  * 
- * {@link "http://www.khronos.org/registry/typedarray/specs/latest/#8"}
+ * @see <a href="https://262.ecma-international.org/6.0/#sec-typedarray-objects">typed array specification</a>
  */
 public interface DataView extends ArrayBufferView {
 

user/src/com/google/gwt/typedarrays/shared/Float32Array.java

@@ -18,7 +18,7 @@
 /**
  * A view representing an {@link ArrayBuffer} as 32-bit floats.
  * 
- * {@link "http://www.khronos.org/registry/typedarray/specs/latest/#7"}
+ * @see <a href="https://262.ecma-international.org/6.0/#sec-typedarray-objects">typed array specification</a>
  */
 public interface Float32Array extends ArrayBufferView {
 

user/src/com/google/gwt/typedarrays/shared/Float64Array.java

@@ -18,7 +18,7 @@
 /**
  * A view representing an {@link ArrayBuffer} as 32-bit floats.
  * 
- * {@link "http://www.khronos.org/registry/typedarray/specs/latest/#7"}
+ * @see <a href="https://262.ecma-international.org/6.0/#sec-typedarray-objects">typed array specification</a>
  */
 public interface Float64Array extends ArrayBufferView {
 

user/src/com/google/gwt/typedarrays/shared/Int16Array.java

@@ -20,7 +20,7 @@
  * out-of-range values are mapped to valid values by taking the bottom 16 bits of
  * the value.
  * 
- * {@link "http://www.khronos.org/registry/typedarray/specs/latest/#7"}
+ * @see <a href="https://262.ecma-international.org/6.0/#sec-typedarray-objects">typed array specification</a>
  */
 public interface Int16Array extends ArrayBufferView {
 

user/src/com/google/gwt/typedarrays/shared/Int32Array.java

@@ -20,7 +20,7 @@
  * out-of-range values are mapped to valid values by taking the bottom 32 bits of
  * the value.
  * 
- * {@link "http://www.khronos.org/registry/typedarray/specs/latest/#7"}
+ * @see <a href="https://262.ecma-international.org/6.0/#sec-typedarray-objects">typed array specification</a>
  */
 public interface Int32Array extends ArrayBufferView {
 

user/src/com/google/gwt/typedarrays/shared/Int8Array.java

@@ -20,7 +20,7 @@
  * out-of-range values are mapped to valid values by taking the bottom 8 bits of
  * the value.
  * 
- * {@link "http://www.khronos.org/registry/typedarray/specs/latest/#7"}
+ * @see <a href="https://262.ecma-international.org/6.0/#sec-typedarray-objects">typed array specification</a>
  */
 public interface Int8Array extends ArrayBufferView {