Skip to content

Allow overriding Super Dev Mode server URL via prompt #10344

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
schteff wants to merge 2 commits into
base: main
Choose a base branch
from
+13 −4
Open

Allow overriding Super Dev Mode server URL via prompt #10344

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
fa941b0
Allow overriding Super Dev Mode server URL via prompt
Jun 15, 2026
0f5941b
Remove sessionStorage availability check in Super Dev Mode stub
Jun 16, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 22 additions & 4 deletions dev/codeserver/java/com/google/gwt/dev/codeserver/stub.nocache.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,8 +20,19 @@
(function($wnd, $doc){
// Compute some codeserver urls so as the user does not need bookmarklets
var hostName = $wnd.location.hostname;
var serverUrl = 'http://' + hostName + ':__SUPERDEV_PORT__';
var module = '__MODULE_NAME__';

// The default Super Dev Mode server url. The user may override it (and retry)
// through the prompt shown by the error handler below; the override is kept
// for the session so the reload picks up the new server.
var serverUrlKey = '__gwt_sdm__server_url';
var defaultServerUrl = 'http://' + hostName + ':__SUPERDEV_PORT__';
var serverUrl = defaultServerUrl;
try {
serverUrl = $wnd.sessionStorage.getItem(serverUrlKey) || defaultServerUrl;
} catch (e) {
// sessionStorage may be unavailable; fall back to the default url.

@niloc132 niloc132 Jun 15, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's the risk/likelihood that session storage is unavailable? dev_mode_on.js relies on it and won't function without it, so I think maybe we can assume it is there?

}
var nocacheUrl = serverUrl + '/recompile-requester/' + module;

// Insert the superdevmode nocache script in the first position of the head
Expand All @@ -32,15 +43,22 @@
// This means that we do not detect a non running SDM with IE8.
if (devModeScript.addEventListener) {
var callback = function() {
// Don't show the confirmation dialogue twice (multimodule)
// Don't show the prompt twice (multimodule)
if (!$wnd.__gwt__sdm__confirmed &&
(!$wnd.__gwt_sdm__recompiler || !$wnd.__gwt_sdm__recompiler.loaded)) {
$wnd.__gwt__sdm__confirmed = true;
if ($wnd.confirm(
var newServerUrl = $wnd.prompt(
"Couldn't load " + module + " from Super Dev Mode\n" +
"server at " + serverUrl + ".\n" +
"Please make sure this server is ready.\n" +
"Do you want to try again?")) {
"Press OK to try again:",
serverUrl);
if (newServerUrl) {
try {
$wnd.sessionStorage.setItem(serverUrlKey, newServerUrl);
} catch (e) {
// Without storage the reload falls back to the default url.

@niloc132 niloc132 Jun 15, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(assuming still relevant) Should probably notify that the prompt had no effect?

Maybe test for storage usage before attempting to use prompt to begin with?

}
$wnd.location.reload();
}
}
Expand Down