Skip to content

fix(#2767): pass paths via --files to gsd-sdk query commit + lint guard #2781

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
trek-e merged 3 commits into from
Apr 27, 2026
Merged

fix(#2767): pass paths via --files to gsd-sdk query commit + lint guard #2781

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
1eb67b7
fix(#2767): pass paths via --files to gsd-sdk query commit + lint guard
trek-e Apr 27, 2026
8579d6d
test(#2767): replace source-grep with behavioral SDK test
trek-e Apr 27, 2026
7eea30f
docs(#2767): correct contradictory --files guidance in zh-CN/en docs …
trek-e Apr 27, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion agents/gsd-code-fixer.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -345,6 +345,7 @@ Use `gsd-sdk query commit` with conventional format (message first, then every s
```bash
gsd-sdk query commit \
"fix({padded_phase}): {finding_id} {short_description}" \
--files \
{all_modified_files}
```

Expand All @@ -354,7 +355,7 @@ Examples:

**Multiple files:** List ALL modified files after the message (space-separated):
```bash
gsd-sdk query commit "fix(02): CR-01 ..." \
gsd-sdk query commit "fix(02): CR-01 ..." --files \
src/api/auth.ts src/types/user.ts tests/auth.test.ts
```

Expand Down
4 changes: 2 additions & 2 deletions agents/gsd-debugger.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1168,7 +1168,7 @@ Root cause: {root_cause}"

Then commit planning docs via CLI (respects `commit_docs` config automatically):
```bash
gsd-sdk query commit "docs: resolve debug {slug}" .planning/debug/resolved/{slug}.md
gsd-sdk query commit "docs: resolve debug {slug}" --files .planning/debug/resolved/{slug}.md
```

**Append to knowledge base:**
Expand Down Expand Up @@ -1199,7 +1199,7 @@ Then append the entry:

Commit the knowledge base update alongside the resolved session:
```bash
gsd-sdk query commit "docs: update debug knowledge base with {slug}" .planning/debug/knowledge-base.md
gsd-sdk query commit "docs: update debug knowledge base with {slug}" --files .planning/debug/knowledge-base.md
```

Report completion and offer next steps.
Expand Down
2 changes: 1 addition & 1 deletion agents/gsd-executor.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -563,7 +563,7 @@ gsd-sdk query state.add-blocker "Blocker description"

<final_commit>
```bash
gsd-sdk query commit "docs({phase}-{plan}): complete [plan-name] plan" \
gsd-sdk query commit "docs({phase}-{plan}): complete [plan-name] plan" --files \
.planning/phases/XX-name/{phase}-{plan}-SUMMARY.md .planning/STATE.md .planning/ROADMAP.md .planning/REQUIREMENTS.md
```

Expand Down
2 changes: 1 addition & 1 deletion agents/gsd-phase-researcher.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -755,7 +755,7 @@ Write to: `$PHASE_DIR/$PADDED_PHASE-RESEARCH.md`
## Step 7: Commit Research (optional)

```bash
gsd-sdk query commit "docs($PHASE): research phase domain" "$PHASE_DIR/$PADDED_PHASE-RESEARCH.md"
gsd-sdk query commit "docs($PHASE): research phase domain" --files "$PHASE_DIR/$PADDED_PHASE-RESEARCH.md"
```

## Step 8: Return Structured Result
Expand Down
2 changes: 1 addition & 1 deletion agents/gsd-planner.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1136,7 +1136,7 @@ Plans:

<step name="git_commit">
```bash
gsd-sdk query commit "docs($PHASE): create phase plan" \
gsd-sdk query commit "docs($PHASE): create phase plan" --files \
.planning/phases/$PHASE-*/$PHASE-*-PLAN.md .planning/ROADMAP.md
```
</step>
Expand Down
2 changes: 1 addition & 1 deletion agents/gsd-research-synthesizer.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -139,7 +139,7 @@ Write to `.planning/research/SUMMARY.md`
The 4 parallel researcher agents write files but do NOT commit. You commit everything together.

```bash
gsd-sdk query commit "docs: complete project research" .planning/research/
gsd-sdk query commit "docs: complete project research" --files .planning/research/
```

## Step 8: Return Summary
Expand Down
2 changes: 1 addition & 1 deletion agents/gsd-ui-researcher.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -292,7 +292,7 @@ Fill all sections. Write to `$PHASE_DIR/$PADDED_PHASE-UI-SPEC.md`.
## Step 6: Commit (optional)

```bash
gsd-sdk query commit "docs($PHASE): UI design contract" "$PHASE_DIR/$PADDED_PHASE-UI-SPEC.md"
gsd-sdk query commit "docs($PHASE): UI design contract" --files "$PHASE_DIR/$PADDED_PHASE-UI-SPEC.md"
```

## Step 7: Return Structured Result
Expand Down
2 changes: 1 addition & 1 deletion commands/gsd/add-backlog.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,7 @@ the normal phase sequence and accumulate context over time.

5. **Commit:**
```bash
gsd-sdk query commit "docs: add backlog item ${NEXT} — ${ARGUMENTS}" .planning/ROADMAP.md ".planning/phases/${NEXT}-${SLUG}/.gitkeep"
gsd-sdk query commit "docs: add backlog item ${NEXT} — ${ARGUMENTS}" --files .planning/ROADMAP.md ".planning/phases/${NEXT}-${SLUG}/.gitkeep"
```

6. **Report:**
Expand Down
2 changes: 1 addition & 1 deletion commands/gsd/review-backlog.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,7 @@ milestone sequence or remove stale entries.

6. **Commit changes:**
```bash
gsd-sdk query commit "docs: review backlog — promoted N, removed M" .planning/ROADMAP.md
gsd-sdk query commit "docs: review backlog — promoted N, removed M" --files .planning/ROADMAP.md
```

7. **Report summary:**
Expand Down
4 changes: 2 additions & 2 deletions commands/gsd/thread.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -83,7 +83,7 @@ When SUBCMD=close and SLUG is set (already sanitized):

3. Commit:
```bash
gsd-sdk query commit "docs: resolve thread — {SLUG}" ".planning/threads/{SLUG}.md"
gsd-sdk query commit "docs: resolve thread — {SLUG}" --files ".planning/threads/{SLUG}.md"
```

4. Print:
Expand Down Expand Up @@ -191,7 +191,7 @@ updated: {today ISO date}

5. Commit:
```bash
gsd-sdk query commit "docs: create thread — ${ARGUMENTS}" ".planning/threads/${SLUG}.md"
gsd-sdk query commit "docs: create thread — ${ARGUMENTS}" --files ".planning/threads/${SLUG}.md"
```

6. Report:
Expand Down
6 changes: 3 additions & 3 deletions docs/zh-CN/references/git-integration.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,7 @@ Phases:
提交内容：

```bash
gsd-sdk query commit "docs: initialize [project-name] ([N] phases)" .planning/
gsd-sdk query commit "docs: initialize [project-name] ([N] phases)" --files .planning/
```

</format>
Expand Down Expand Up @@ -129,7 +129,7 @@ SUMMARY: .planning/phases/XX-name/{phase}-{plan}-SUMMARY.md
提交内容：

```bash
gsd-sdk query commit "docs({phase}-{plan}): complete [plan-name] plan" .planning/phases/XX-name/{phase}-{plan}-PLAN.md .planning/phases/XX-name/{phase}-{plan}-SUMMARY.md .planning/STATE.md .planning/ROADMAP.md
gsd-sdk query commit "docs({phase}-{plan}): complete [plan-name] plan" --files .planning/phases/XX-name/{phase}-{plan}-PLAN.md .planning/phases/XX-name/{phase}-{plan}-SUMMARY.md .planning/STATE.md .planning/ROADMAP.md
```

**注意：** 代码文件不包含 - 已按任务提交。
Expand All @@ -149,7 +149,7 @@ Current: [task name]
提交内容：

```bash
gsd-sdk query commit "wip: [phase-name] paused at task [X]/[Y]" .planning/
gsd-sdk query commit "wip: [phase-name] paused at task [X]/[Y]" --files .planning/
```

</format>
Expand Down
4 changes: 2 additions & 2 deletions docs/zh-CN/references/git-planning-commit.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@
对 `.planning/` 文件始终使用此方式 —— 它会自动处理 `commit_docs` 与 gitignore 检查：

```bash
gsd-sdk query commit "docs({scope}): {description}" .planning/STATE.md .planning/ROADMAP.md
gsd-sdk query commit "docs({scope}): {description}" --files .planning/STATE.md .planning/ROADMAP.md
Comment thread
coderabbitai[bot] marked this conversation as resolved.
```

如果 `commit_docs` 为 `false` 或 `.planning/` 被 gitignore，CLI 会返回 `skipped`（带原因）。无需手动条件检查。
Expand All @@ -19,7 +19,7 @@ gsd-sdk query commit "docs({scope}): {description}" .planning/STATE.md .planning
将 `.planning/` 文件变更合并到上次提交：

```bash
gsd-sdk query commit "" .planning/codebase/*.md --amend
gsd-sdk query commit "" --files .planning/codebase/*.md --amend
```

## 提交消息模式
Expand Down
4 changes: 2 additions & 2 deletions docs/zh-CN/references/planning-config.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@

```bash
# 提交时自动检查 commit_docs + gitignore：
gsd-sdk query commit "docs: update state" .planning/STATE.md
gsd-sdk query commit "docs: update state" --files .planning/STATE.md

# 通过 state load 加载配置（返回 JSON）：
INIT=$(gsd-sdk query state.load)
Expand All @@ -58,7 +58,7 @@ if [[ "$INIT" == @file:* ]]; then INIT=$(cat "${INIT#@file:}"); fi
**通过 CLI 提交（自动处理检查）：**

```bash
gsd-sdk query commit "docs: update state" .planning/STATE.md
gsd-sdk query commit "docs: update state" --files .planning/STATE.md
```

CLI 在内部检查 `commit_docs` 配置和 gitignore 状态 —— 无需手动条件判断。
Expand Down
2 changes: 1 addition & 1 deletion get-shit-done/references/autonomous-smart-discuss.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -266,7 +266,7 @@ Write the file.
**Commit:**

```bash
gsd-sdk query commit "docs(${PADDED_PHASE}): smart discuss context" "${phase_dir}/${padded_phase}-CONTEXT.md"
gsd-sdk query commit "docs(${PADDED_PHASE}): smart discuss context" --files "${phase_dir}/${padded_phase}-CONTEXT.md"
```

Display confirmation:
Expand Down
6 changes: 3 additions & 3 deletions get-shit-done/references/git-integration.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,7 @@ Phases:
What to commit:

```bash
gsd-sdk query commit "docs: initialize [project-name] ([N] phases)" .planning/
gsd-sdk query commit "docs: initialize [project-name] ([N] phases)" --files .planning/
```

</format>
Expand Down Expand Up @@ -133,7 +133,7 @@ SUMMARY: .planning/phases/XX-name/{phase}-{plan}-SUMMARY.md
What to commit:

```bash
gsd-sdk query commit "docs({phase}-{plan}): complete [plan-name] plan" .planning/phases/XX-name/{phase}-{plan}-PLAN.md .planning/phases/XX-name/{phase}-{plan}-SUMMARY.md .planning/STATE.md .planning/ROADMAP.md
gsd-sdk query commit "docs({phase}-{plan}): complete [plan-name] plan" --files .planning/phases/XX-name/{phase}-{plan}-PLAN.md .planning/phases/XX-name/{phase}-{plan}-SUMMARY.md .planning/STATE.md .planning/ROADMAP.md
```

**Note:** Code files NOT included - already committed per-task.
Expand All @@ -153,7 +153,7 @@ Current: [task name]
What to commit:

```bash
gsd-sdk query commit "wip: [phase-name] paused at task [X]/[Y]" .planning/
gsd-sdk query commit "wip: [phase-name] paused at task [X]/[Y]" --files .planning/
```

</format>
Expand Down
4 changes: 2 additions & 2 deletions get-shit-done/references/git-planning-commit.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ Pass the message first, then file paths (positional). Do not use `--files` for `
Always use this for `.planning/` files — it handles `commit_docs` and gitignore checks automatically:

```bash
gsd-sdk query commit "docs({scope}): {description}" .planning/STATE.md .planning/ROADMAP.md
gsd-sdk query commit "docs({scope}): {description}" --files .planning/STATE.md .planning/ROADMAP.md
```

The CLI will return `skipped` (with reason) if `commit_docs` is `false` or `.planning/` is gitignored. No manual conditional checks needed.
Expand All @@ -19,7 +19,7 @@ The CLI will return `skipped` (with reason) if `commit_docs` is `false` or `.pla
To fold `.planning/` file changes into the previous commit:

```bash
gsd-sdk query commit "" .planning/codebase/*.md --amend
gsd-sdk query commit "" --files .planning/codebase/*.md --amend
```

## Commit Message Patterns
Expand Down
2 changes: 1 addition & 1 deletion get-shit-done/references/planner-revision.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,7 @@ Group by plan, dimension, severity.
### Step 6: Commit

```bash
gsd-sdk query commit "fix($PHASE): revise plans based on checker feedback" .planning/phases/$PHASE-*/$PHASE-*-PLAN.md
gsd-sdk query commit "fix($PHASE): revise plans based on checker feedback" --files .planning/phases/$PHASE-*/$PHASE-*-PLAN.md
```

### Step 7: Return Revision Summary
Expand Down
4 changes: 2 additions & 2 deletions get-shit-done/references/planning-config.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,7 +58,7 @@ Configuration options for `.planning/` directory behavior.

```bash
# Commit with automatic commit_docs + gitignore checks:
gsd-sdk query commit "docs: update state" .planning/STATE.md
gsd-sdk query commit "docs: update state" --files .planning/STATE.md

# Load config via state load (returns JSON):
INIT=$(gsd-sdk query state.load)
Expand All @@ -76,7 +76,7 @@ if [[ "$INIT" == @file:* ]]; then INIT=$(cat "${INIT#@file:}"); fi
**Commit via CLI (handles checks automatically):**

```bash
gsd-sdk query commit "docs: update state" .planning/STATE.md
gsd-sdk query commit "docs: update state" --files .planning/STATE.md
```

The CLI checks `commit_docs` config and gitignore status internally — no manual conditionals needed.
Expand Down
2 changes: 1 addition & 1 deletion get-shit-done/workflows/add-todo.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -121,7 +121,7 @@ If `.planning/STATE.md` exists:
Commit the todo and any updated state:

```bash
gsd-sdk query commit "docs: capture todo - [title]" .planning/todos/pending/[filename] .planning/STATE.md
gsd-sdk query commit "docs: capture todo - [title]" --files .planning/todos/pending/[filename] .planning/STATE.md
```

Tool respects `commit_docs` config and gitignore automatically.
Expand Down
2 changes: 1 addition & 1 deletion get-shit-done/workflows/autonomous.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -249,7 +249,7 @@ None — discuss phase skipped.
Commit the minimal context:

```bash
gsd-sdk query commit "docs(${PADDED_PHASE}): auto-generated context (discuss skipped)" "${phase_dir}/${padded_phase}-CONTEXT.md"
gsd-sdk query commit "docs(${PADDED_PHASE}): auto-generated context (discuss skipped)" --files "${phase_dir}/${padded_phase}-CONTEXT.md"
```

Proceed to 3b.
Expand Down
2 changes: 1 addition & 1 deletion get-shit-done/workflows/check-todos.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -157,7 +157,7 @@ If todo was moved to done/, commit the change:

```bash
git rm --cached .planning/todos/pending/[filename] 2>/dev/null || true
gsd-sdk query commit "docs: start work on todo - [title]" .planning/todos/completed/[filename] .planning/STATE.md
gsd-sdk query commit "docs: start work on todo - [title]" --files .planning/todos/completed/[filename] .planning/STATE.md
```

Tool respects `commit_docs` config and gitignore automatically.
Expand Down
2 changes: 1 addition & 1 deletion get-shit-done/workflows/cleanup.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -124,7 +124,7 @@ Repeat for all milestones in the cleanup set.
Commit the changes:

```bash
gsd-sdk query commit "chore: archive phase directories from completed milestones" .planning/milestones/ .planning/phases/
gsd-sdk query commit "chore: archive phase directories from completed milestones" --files .planning/milestones/ .planning/phases/
```

</step>
Expand Down
4 changes: 2 additions & 2 deletions get-shit-done/workflows/complete-milestone.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -494,7 +494,7 @@ Append the extracted Backlog content verbatim to the end of the newly written RO
**Safety commit — commit archive files BEFORE deleting any originals:**

```bash
gsd-sdk query commit "chore: archive v[X.Y] milestone files" .planning/milestones/v[X.Y]-ROADMAP.md .planning/milestones/v[X.Y]-REQUIREMENTS.md .planning/milestones/v[X.Y]-MILESTONE-AUDIT.md .planning/MILESTONES.md .planning/PROJECT.md .planning/STATE.md .planning/ROADMAP.md
gsd-sdk query commit "chore: archive v[X.Y] milestone files" --files .planning/milestones/v[X.Y]-ROADMAP.md .planning/milestones/v[X.Y]-REQUIREMENTS.md .planning/milestones/v[X.Y]-MILESTONE-AUDIT.md .planning/MILESTONES.md .planning/PROJECT.md .planning/STATE.md .planning/ROADMAP.md
```

This creates a durable checkpoint in git history. If anything fails after this point, the working tree can be reconstructed from git.
Expand Down Expand Up @@ -563,7 +563,7 @@ If the "## Cross-Milestone Trends" section exists, update the tables with new da

**Commit:**
```bash
gsd-sdk query commit "docs: update retrospective for v${VERSION}" .planning/RETROSPECTIVE.md
gsd-sdk query commit "docs: update retrospective for v${VERSION}" --files .planning/RETROSPECTIVE.md
```

</step>
Expand Down
2 changes: 1 addition & 1 deletion get-shit-done/workflows/diagnose-issues.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -179,7 +179,7 @@ Update status in frontmatter to "diagnosed".

Commit the updated UAT.md:
```bash
gsd-sdk query commit "docs({phase_num}): add root causes from diagnosis" ".planning/phases/XX-name/{phase_num}-UAT.md"
gsd-sdk query commit "docs({phase_num}): add root causes from diagnosis" --files ".planning/phases/XX-name/{phase_num}-UAT.md"
```
</step>

Expand Down
4 changes: 2 additions & 2 deletions get-shit-done/workflows/discuss-phase-assumptions.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -552,7 +552,7 @@ Write file.
Commit phase context and discussion log:

```bash
gsd-sdk query commit "docs(${padded_phase}): capture phase context (assumptions mode)" "${phase_dir}/${padded_phase}-CONTEXT.md" "${phase_dir}/${padded_phase}-DISCUSSION-LOG.md"
gsd-sdk query commit "docs(${padded_phase}): capture phase context (assumptions mode)" --files "${phase_dir}/${padded_phase}-CONTEXT.md" "${phase_dir}/${padded_phase}-DISCUSSION-LOG.md"
```

Confirm: "Committed: docs(${padded_phase}): capture phase context (assumptions mode)"
Expand All @@ -570,7 +570,7 @@ gsd-sdk query state.record-session \
Commit STATE.md:

```bash
gsd-sdk query commit "docs(state): record phase ${PHASE} context session" .planning/STATE.md
gsd-sdk query commit "docs(state): record phase ${PHASE} context session" --files .planning/STATE.md
```
</step>

Expand Down
4 changes: 2 additions & 2 deletions get-shit-done/workflows/discuss-phase.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -445,7 +445,7 @@ rm -f "${phase_dir}/${padded_phase}-DISCUSS-CHECKPOINT.json"

Commit phase context and discussion log:
```bash
gsd-sdk query commit "docs(${padded_phase}): capture phase context" "${phase_dir}/${padded_phase}-CONTEXT.md" "${phase_dir}/${padded_phase}-DISCUSSION-LOG.md"
gsd-sdk query commit "docs(${padded_phase}): capture phase context" --files "${phase_dir}/${padded_phase}-CONTEXT.md" "${phase_dir}/${padded_phase}-DISCUSSION-LOG.md"
```

Confirm: "Committed: docs(${padded_phase}): capture phase context"
Expand All @@ -459,7 +459,7 @@ gsd-sdk query state.record-session \
--stopped-at "Phase ${PHASE} context gathered" \
--resume-file "${phase_dir}/${padded_phase}-CONTEXT.md"

gsd-sdk query commit "docs(state): record phase ${PHASE} context session" .planning/STATE.md
gsd-sdk query commit "docs(state): record phase ${PHASE} context session" --files .planning/STATE.md
```
</step>

Expand Down
Loading