Skip to content

chore(core): update models pricing snapshot - #492

Merged
szanata merged 1 commit into
mainfrom
chore/take-models-pricing-snapshot
Nov 11, 2026
Merged

szanata merged 1 commit into
mainfrom
chore/take-models-pricing-snapshot

Conversation

@GrowthX-Team

Copy link
Copy Markdown
Collaborator

Automated changes by create-pull-request GitHub action

{
"_meta": {
"createdAt": "2026-11-02T06:16:58.558Z"
"createdAt": "2026-11-09T06:16:59.736Z"

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice-to-have (Quality): this timestamp is the only change in the PR — all 4700 lines of pricing data are byte-identical. _meta.createdAt is never read at runtime (models_pricing.js skips _meta), so the weekly job opens a churn PR even when nothing changed. Consider having take_models_pricing_snapshot.js keep the existing createdAt when provider data is unchanged.

@github-actions

github-actions Bot commented Nov 9, 2026

Copy link
Copy Markdown
Contributor

PR review

Verdict

✅ PASS

Findings

  1. Nice-to-have (Quality): The only change in this PR is _meta.createdAt in sdk/core/src/llm/utils/models_pricing_snapshot.json — all ~4700 lines of pricing data are byte-identical, and createdAt is never read at runtime (models_pricing.js skips _meta). The weekly job therefore opens a churn PR even when upstream pricing is unchanged; consider having scripts/take_models_pricing_snapshot.js preserve the existing stamp (or skip the write) when provider data is unchanged.

Categories

  • Design: ✅ PASS
  • Quality: ✅ PASS
  • Correctness: ✅ PASS
  • Documentation: ✅ PASS
  • Changeset: ✅ PASS
  • Tests: ✅ PASS
  • Security: ✅ PASS
  • Compatibility: ✅ PASS

@szanata
szanata merged commit ac69246 into main Nov 11, 2026
10 checks passed
@szanata
szanata deleted the chore/take-models-pricing-snapshot branch November 11, 2026 15:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants