-
Notifications
You must be signed in to change notification settings - Fork 13
Update vcfpy dependency to a newer version #84
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -16,11 +16,12 @@ | |
| ] | ||
| }, | ||
| install_requires=[ | ||
| 'vcfpy==0.12.3', | ||
| 'vcfpy==0.13.8', | ||
|
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. should we bump this to the newest (0.14.2) at this point?
Collaborator
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I feel like there was some reason to pin this version but I don't remember. I think I was trying to keep it in line with what pVACtools uses (which isn't really required). There might also be some incompatibility with python versions and/or other dependencies. |
||
| 'pysam', | ||
| 'pandas', | ||
| 'gtfparse==1.3.0', | ||
| 'testfixtures', | ||
| 'distutils-strtobool', | ||
| ], | ||
| classifiers=[ | ||
| 'Development Status :: 5 - Production/Stable', | ||
|
|
||
Large diffs are not rendered by default.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we be bumping this list to support later versions (up to 3.14) now?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure. We might run into some dependency incompatibility so we'd need to decide how to best resolve them.