Removed dead code, including functionality for using ecdh to derive keys which currently isn't supported by this module#126
Closed
joeybright wants to merge 5 commits into
Closed
Conversation
This algorithm is only used for deriving keys in the Web Crypto API, which is not yet supported by this module.
Member
|
@joeybright do you know why the tests fail to run? |
Contributor
Author
|
@robinheghan I setup key signing, but not sure how to do that retroactively (or if that's even possible). I can submit a small commit to test? (Edit: Signing seems to be working with commit to this PR) As for tests failing, I did not update my fork before making these changes. Rookie mistake, my bad! Updated it and removed an export that is no longer needed. Tests are now passing for me locally. |
Contributor
Author
|
@robinheghan Made another pull request (#128) with the dead code removal changes and clean git history. Don't want to muck up the repo with my mistakes! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.