Skip to content

Support .cjs config files #129

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
guillaumervls wants to merge 3 commits into from
+8 −2
Closed

Support .cjs config files #129

Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
eb72b51
Support .cjs config files
guillaumervls Jun 21, 2021
c87dea9
Update _common.ts
guillaumervls Jul 2, 2021
67b06b2
Update src/commands/_common.ts
guillaumervls Jul 2, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 8 additions & 2 deletions src/commands/_common.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,8 @@ import { Settings } from "../settings";

export const DEFAULT_GMRC_PATH = `${process.cwd()}/.gmrc`;
export const DEFAULT_GMRCJS_PATH = `${DEFAULT_GMRC_PATH}.js`;
export const DEFAULT_GMRCCJS_PATH = `${DEFAULT_GMRC_PATH}.cjs`;
export const DEFAULT_GMRCMJS_PATH = `${DEFAULT_GMRC_PATH}.mjs`;

/**
* Represents the option flags that are valid for all commands (see
Expand Down Expand Up @@ -70,7 +72,7 @@ export async function getSettings(options: Options = {}): Promise<Settings> {
const relativePath = resolve(process.cwd(), path);

try {
return require(relativePath);
return relativePath.endsWith(".mjs") ? import(relativePath) : require(relativePath);
Comment thread
guillaumervls marked this conversation as resolved.
Outdated
} catch (e) {
throw new Error(
`Failed to import '${relativePath}'; error:\n ${e.stack.replace(
Expand All @@ -86,7 +88,7 @@ export async function getSettings(options: Options = {}): Promise<Settings> {
throw new Error(`Failed to import '${configFile}': file not found`);
}

if (configFile.endsWith(".js")) {
if (configFile.endsWith(".js") || configFile.endsWith(".cjs") || configFile.endsWith(".mjs")) {
return tryRequire(configFile);
} else {
return await getSettingsFromJSON(configFile);
Expand All @@ -95,6 +97,10 @@ export async function getSettings(options: Options = {}): Promise<Settings> {
return await getSettingsFromJSON(DEFAULT_GMRC_PATH);
} else if (await exists(DEFAULT_GMRCJS_PATH)) {
return tryRequire(DEFAULT_GMRCJS_PATH);
} else if (await exists(DEFAULT_GMRCCJS_PATH)) {
return tryRequire(DEFAULT_GMRCCJS_PATH);
} else if (await exists(DEFAULT_GMRCMJS_PATH)) {
return tryRequire(DEFAULT_GMRCMJS_PATH);
} else {
throw new Error(
"No .gmrc file found; please run `graphile-migrate init` first.",
Expand Down