[Backport] [Oracle GraalVM] [GR-71539] Backport to 23.1: TruffleStrings: fix incorrect offset handling in FromJavaStringNode.#274
Open
bulasevich wants to merge 1 commit intograalvm:masterfrom
Open
Conversation
(cherry picked from commit 9b57a1aa02fece51257465637e38ebced0ab7bc7)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR backports:
Conflicts:
change: moves IF condition under length1Profile.profile call
issue: mainline IF condition uses TStringOps.readFromByteArrayS1 introduced by 0b835c83 TruffleStrings: internal refactor
resolution: use the old IF condition, but move it under the length1Profile.profile call
change: modifies the String hash calculation passed as a parameter to createFromByteArray
issue: not applicable without 4dc61ab9 Preserve already computed hash code in Java String to TruffleString conversion.
resolution: skipped
Closes: #257
Test TStringFromJavaStringTest passed.