Skip to content

[Backport] [Oracle GraalVM] [GR-70295] Backport to 23.1: Use opaque placeholder value when deleting a VirtualFrameAccessorNode #264

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
bulasevich wants to merge 1 commit into
base: master
Choose a base branch
from
Open

[Backport] [Oracle GraalVM] [GR-70295] Backport to 23.1: Use opaque placeholder value when deleting a VirtualFrameAccessorNode #264

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 6 additions & 4 deletions ...piler/src/org/graalvm/compiler/truffle/compiler/nodes/frame/VirtualFrameAccessorNode.java
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
/*
* Copyright (c) 2016, 2023, Oracle and/or its affiliates. All rights reserved.
* Copyright (c) 2016, 2025, Oracle and/or its affiliates. All rights reserved.
* DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
*
* This code is free software; you can redistribute it and/or modify it
Expand Down Expand Up @@ -30,6 +30,7 @@
import org.graalvm.compiler.core.common.type.Stamp;
import org.graalvm.compiler.graph.NodeClass;
import org.graalvm.compiler.nodeinfo.NodeInfo;
import org.graalvm.compiler.nodes.extended.OpaqueValueNode;
import org.graalvm.compiler.nodes.ConstantNode;
import org.graalvm.compiler.nodes.FixedGuardNode;
import org.graalvm.compiler.nodes.FixedWithNextNode;
Expand Down Expand Up @@ -114,10 +115,11 @@ protected final void insertDeoptimization(VirtualizerTool tool) {
tool.delete();
} else {
/*
* Even though all usages will be eventually dead, we need to provide a valid
* replacement value for now.
* Even though all usages will be eventually dead, we need to provide a placeholder
* replacement value for now. This must be opaque to prevent transformations based on
* this value before the deletion takes effect.
*/
ConstantNode unusedValue = ConstantNode.forConstant(JavaConstant.defaultForKind(getStackKind()), tool.getMetaAccess());
ValueNode unusedValue = new OpaqueValueNode(ConstantNode.forConstant(JavaConstant.defaultForKind(getStackKind()), tool.getMetaAccess()));
tool.addNode(unusedValue);
tool.replaceWith(unusedValue);
}
Expand Down
Loading