Skip to content

Expand Glyphs multiple languages syntax when building UFOs #1162

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
tomekthewo wants to merge 8 commits into
base: main
Choose a base branch
from
+1,270 −0
Open

Expand Glyphs multiple languages syntax when building UFOs #1162

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
3617477
Expand Glyphs multiple languages syntax when building UFOs
tomekthewo Sep 2, 2026
e8864b5
Document that the language expansion is one-way
tomekthewo Sep 2, 2026
7ec32ae
Ignore comments and strings when scanning feature code
tomekthewo Sep 2, 2026
c1e8223
Reuse the shared comment blanking helper
tomekthewo Sep 2, 2026
b354bdb
Assert the whole expanded output in the tests
tomekthewo Sep 2, 2026
16ad82e
Rewrite the multi-language expansion on feaLib's Lexer
tomekthewo Sep 7, 2026
15014d8
Expand multi-language statements after the variable feature conversion
tomekthewo Sep 7, 2026
751b977
Leave malformed multi-language statements alone
tomekthewo Sep 7, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions Lib/glyphsLib/builder/features.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,6 +34,7 @@
INSERT_FEATURE_MARKER_COMMENT,
)
from .tokens import TokenExpander, PassThruExpander
from .multi_language import expand_multi_language_statements
from .variable_features import VariableFeatureConverter

if TYPE_CHECKING:
Expand Down Expand Up @@ -198,6 +199,12 @@ def _to_ufo_features( # noqa: C901
if master is not None:
full_text = VariableFeatureConverter(font).convert(full_text)

# Expand Glyphs' multiple languages syntax (`language AZE CRT;`) into the
# one-tag-per-statement form the FEA spec allows. After the conversion
# above, so that `#ifndef VARIABLE` blocks are already resolved and no rule
# is ever replayed out of one.
full_text = expand_multi_language_statements(full_text)

if not full_text or not expand_includes:
return full_text

Expand Down
Loading
Loading