Take on smallvec in read-fonts and skrifa - #2081
Open
dfrg wants to merge 1 commit into
Open
Conversation
We've had a hand-rolled partial implementation in skrifa for some time. We've since grown another, even more partial, implementation as well as several open coded copies of this pattern (conditional stack alloc or vec) in read-fonts. This dependency is ubiquitous in the rust ecosystem and available in all of our target environments. I've chosen the floor of those versions (1.13.1) here.
cmyr
approved these changes
Aug 26, 2026
cmyr
left a comment
cmyr
left a comment
Member
There was a problem hiding this comment.
as long as it doesn't introduce vendoring issues it lgtm.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We've had a hand-rolled partial implementation in skrifa for some time. We've since grown another, even more partial, implementation as well as several open coded copies of this pattern (conditional stack alloc or vec) in read-fonts.
This dependency is ubiquitous in the rust ecosystem and available in all of our target environments. I've chosen the floor of those versions (1.13.1) here.